Edgewall Software

Ticket #967 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

xml like patch not escaped properly

Reported by: johan@… Owned by: jonas
Priority: normal Milestone: 0.9
Component: ticket system Version: 0.8
Severity: normal Keywords:
Cc: johan@…

Description

A patch like this:

Index: flumotion/component/producers/webcam/webcam.xml
===================================================================
--- flumotion/component/producers/webcam/webcam.xml     (revision 1164)
+++ flumotion/component/producers/webcam/webcam.xml     (working copy)
@@ -4,6 +4,7 @@
       <source location="flumotion.component.producers.webcam.webcam"/>
       <properties>
         <property name="feed" type="string" required="yes" multiple="yes"/>
+        <property name="device" type="string" required="yes"/>
         <property name="height" type="int"/>
         <property name="width" type="int"/>
         <property name="framerate" type="float"/>

is rendered like this:

<span class="code-string"><B>Index: flumotion/component/producers/webcam/webcam.xml
</span></B>
<span lass="code-string"><B>===================================================================
</span></B>
<B><span class="code-func">--- flumotion/component/producers/webcam/webcam.xml	(revision 1164)
</span></B>
<B><span class="code-keyword">+++ flumotion/component/producers/webcam/webcam.xml	(working copy)
</span></B>
<I><span class="code-comment">@@ -4,6 +4,7 @@
</span></I>
       <source location="flumotion.component.producers.webcam.webcam"/>
       <properties>
         <property name="feed" type="string" required="yes" multiple="yes"/>
<B><span class="code-keyword">+        &lt;property name=&quot;device&quot; type=&quot;string&quot; required=&quot;yes&quot;/&gt;

</span></B>         <property name="height" type="int"/>
         <property name="width" type="int"/>
         <property name="framerate" type="float"/>
</PRE></div>

Which makes all lines with < and > to be not rendered at all.

For an example. see this url: https://core.fluendo.com/trac/cgi-bin/trac.cgi/attachment/ticket/110/webcam-device-property.patch

Attachments

xml-rendering.patch (0.6 KB) - added by anonymous 4 years ago.
testcase

Change History

Changed 4 years ago by anonymous

testcase

Changed 4 years ago by cmlenz

This appears to be a problem with enscript.

Changed 3 years ago by mgood

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.9

Since Trac now provides it's own mimeviewer to display diff files like the changeset diffs, this problem is fixed.

Changed 3 years ago by mgood

And actually it seems like the enscript formatting works too since the patch attached to this ticket displays properly without the newer diff viewer.

Add/Change #967 (xml like patch not escaped properly)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from jonas. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.