no email notification on ticket change via SVN commit command "refs"

[hw@…]

When you checkin a changeset and use the "refs #<ticket_nr>" command no notification is send. Normal ticket change like adding comment works well.

[cmlenz]

What is the "SVN commit command 'refs'"?

$ svn refs --help
"refs": unknown command.

[cmlenz]

Oh, you're talking about the post-commit hook?

[anonymous]

yes exactly.

[anonymous]

We just checked, also closing via "post-commt hook" does not send a notification email.

[mrowe]

I believe the post-commit hook modifies the database directly. The module that provides the functionality needed should probably be refactored so that the post-commit hook can use it to make the changes.

[mgood]

#1508 has been marked as a duplicate of this ticket

[xris]

as I mentioned in #1508, the post-commit hook uses ticket.save_changes(). I don't mind helping to fix this, but need to know from the devs if it should be fixed in the hook (by adding a call to whatever method sends the emails) or in the trac code (by making save_changes() send the email).

[mgood]

This was actually fixed a while back with [1497], but just got overlooked in the list of fixed tickets. I've tested it out and it's working as expected.

[mgood]

Oops, my mistake. This still doesn't work. I was testing stuff and got an email that I thought was from the commit closing the ticket, but it wasn't.

[anonymous]

Diff of a working fix to the current trunk version

[sitharus@…]

I've attached a patch which fixes the problem on my system.

[sitharus@…]

A working diff from the current trunk.

[sitharus@…]

Attached a working patch, the last one doubled up a command line option, early morning.

[xris <xris*siliconmechanics*com>]

patch against current post-commit script, [1497]

[xris <xris*siliconmechanics*com>]

tried the second diff that was posted, and it didn't apply cleanly to the current tree, so I took my current working ticket-emailer and added a few things:

* corrects the commented example to use -s instead of the incorrect -u for url * pulls trac.ini project url in if no url is passed in via -s * imho much simpler code, and in my case, it actually works.

[anonymous]

Applied to trunk, thanks!

[jonas]

oops, forgot to login.