Edgewall Software
Modify

Ticket #9417 (closed defect: fixed)

Opened 3 months ago

Last modified 6 weeks ago

[PATCH] Genshi UnicodeDecodeError (Admin > General > Plugin)

Reported by: recena@… Owned by: Manuel Jesús Recena Soto <recena@…>
Priority: high Milestone: 0.11.8
Component: admin/web Version: 0.11.7
Severity: minor Keywords:
Cc:

Description

I have the following problem:

500 Trac Error (Genshi UnicodeDecodeError error while rendering
template '/usr/lib/python2.5/site-packages/Trac-0.11.6-py2.5.egg/trac/admin/templates/admin_plugins.html',
line 54, char -1)

You can see that I'm using Python 2.5. This problem happens when I try to install  CmisTracPlugin (a new plugin for trac). This plugin contains the following configuration in  setup.py.

I have special characters. Viewing trac code I have found that only unicode transforms the attribute name and not others (i.e. description): http://trac.edgewall.org/browser/tags/trac-0.11.7/trac/admin/web_ui.py#L525

Between lines 542 - 548.

I have prepared a patch.

Attachments

9417.diff (987 bytes) - added by Manuel Jesús Recena Soto <recena@…> 3 months ago.

Change History

Changed 3 months ago by Manuel Jesús Recena Soto <recena@…>

comment:1 Changed 3 months ago by Manuel Jesús Recena Soto <recena@…>

  • Summary changed from Genshi UnicodeDecodeError (Admin > General > Plugin) to [PATCH] Genshi UnicodeDecodeError (Admin > General > Plugin)

comment:2 follow-up: ↓ 4 Changed 3 months ago by cboos

I'm getting crazy, I'm quite sure this came up before and recently, but I can't find the ticket anymore. In that ticket I can't find, it was said that we should do something similar than what we did for the author in #8444...

Anyway, thanks for the patch!

comment:3 follow-up: ↓ 5 Changed 3 months ago by rblank

This should go into 0.12 as well, right?

comment:4 in reply to: ↑ 2 Changed 3 months ago by Manuel Jesús Recena Soto <recena@…>

Replying to cboos:

I'm getting crazy, I'm quite sure this came up before and recently, but I can't find the ticket anymore. In that ticket I can't find, it was said that we should do something similar than what we did for the author in #8444...

Anyway, thanks for the patch!

Hi cboos:

Certainly the bugs are related. That patch did not solve the problem completely.

Regards,

comment:5 in reply to: ↑ 3 Changed 3 months ago by Manuel Jesús Recena Soto <recena@…>

Replying to rblank:

This should go into 0.12 as well, right?

Hi rblank:

Are you very saturated with work? Maybe you need more commiters ;)

Regards,

comment:6 follow-up: ↓ 7 Changed 2 months ago by cboos

  • Owner set to Manuel Jesús Recena Soto <recena@…>

I'll apply the patch soon.

comment:7 in reply to: ↑ 6 Changed 2 months ago by anonymous

Replying to cboos:

I'll apply the patch soon.

Hi cboos,

I'm using the patch and it seems to work correctly. Ok. I'll wait.

Regars,

comment:8 Changed 6 weeks ago by rblank

The patch has been applied in [9925], but still needs to be merged forward.

comment:9 Changed 6 weeks ago by rblank

  • Status changed from new to closed
  • Resolution set to fixed

[9925] has been merged to both 0.12-stable and trunk.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from Manuel Jesús Recena Soto <recena@…>. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.