[PATCH] Allow aligning custom fields by specifying CSS style for them

[pkou <pkou at ua.fm>]

Currently, there is no way to display custom fields in two columns, e.g. as main ticket fields are displayed.

The proposal is to implement this feature by adding customfield.class parameter for custom fields in trac.ini:

• When this parameter is not specified, Trac uses current approach:
  • Every custom field is added into <div class="field custom_name"> section;
  • Dashed line is added between main fields and custom fields.
• When .class is specified, Trac uses new approach:
  • Every custom field with .class parameter starts new <div class="class"> section;
  • Custom fields without .class paramter that follow a field with this paramter belong to the same class. The fields are separated using <br /> tag;
  • No special separator is added between main and custom fields.
• It is possible to mix old and new approach:
  • All custom fields before first field with .class paramter are processed in old way;
  • For other fields, it is necessary to specify their class in trac.ini explicitly.

Also, three special classes are predefined:

• custom: Starting a new section and draw a dashed line above it;
• col1custom: Starting first column with dashed line above it;
• col2custom: Starting second column with dashed line above it.

Example setup for custom ticket fields is in attached file customalign.ini. Also, attached picture customalign.png shows the result for this setup.

Patch attached also.

[pkou <pkou at ua.fm>]

Example [ticket-custom] setup for trac.ini

[pkou <pkou at ua.fm>]

Result of using customalign.ini on the patch

[pkou <pkou at ua.fm>]

Patch for the changes

[steffenp@…]

I have modified the style sheet and the output generated by macros.py to use the <label for="..."> to align the custom fields like the other fields in the "Change Properties" box (see screenshot). I have also attached a patch.

[mgood]

I'll do some browser testing on this since this type of thing tends to be frustrating to get working in IE. If everthing seems kosher I'll try to get this in soon.

[steffenp@…]

Fixed alignment of radio buttons

[steffenp@…]

I have attached an improved patch that has been tested with konqueror, firefox and IE 6.0.

[steffenp@…]

updated patch to current svn

[mgood]

This has actually been fixed at some point, but I don't know which revision.

[pkou at ua.fm]

Custom fields added after a custom field with type textarea cannot be adjusted automatically and look ugly.

Tested on trunk [1850]

Example custom fields:

[ticket-custom]
test_cases       = textarea
test_cases.order = 1
test_cases.label = Test cases
test_cases.cols  = 10
test_cases.rows  = 2

info = text
info.order = 2
info.label = Info

keywords2       = textarea
keywords2.order = 3
keywords2.label = Other keywords
keywords2.cols  = 70
keywords2.rows  = 3

info2 = text
info.order = 4
info.label = Info 2

[cboos]

I think that should fix it:

templates/newticket.cs

@@ -85 +85 @@
       /if ?></td><?cs
      if:idx % 2 ?></tr><tr><?cs
      elif:idx == num_fields - 1 ?><th class="col2"></th><td></td><?cs
-     /if ?><?cs set:idx = idx + #fullrow + 1 ?><?cs
+     /if ?><?cs set:idx = idx + 1 ?><?cs
     /if ?><?cs
    /each ?></tr>
   </table>

templates/ticket.cs

@@ -67 +67 @@
       var:name(field) ?>"><?cs var:ticket[name(field)] ?></td><?cs
     if:idx % 2 ?></tr><tr><?cs
     elif:idx == num_fields - 1 ?><th></th><td></td><?cs
-    /if ?><?cs set:idx = idx + #fullrow + 1 ?><?cs
+    /if ?><?cs set:idx = idx + 1 ?><?cs
    /if ?><?cs
   /each ?></tr>
  </table>
@@ -207 +207 @@
       /if ?></td><?cs
      if:idx % 2 ?></tr><tr><?cs
      elif:idx == num_fields - 1 ?><th class="col2"></th><td></td><?cs
-     /if ?><?cs set:idx = idx + #fullrow + 1 ?><?cs
+     /if ?><?cs set:idx = idx + 1 ?><?cs
     /if ?><?cs
    /each ?></tr>
   </table>

[cboos]

Another attempt:

templates/ticket.cs

@@ -65 +65 @@
     <th id="h_<?cs var:name(field) ?>"><?cs var:field.label ?>:</th>
     <td<?cs if:fullrow ?> colspan="3"<?cs /if ?> headers="h_<?cs
       var:name(field) ?>"><?cs var:ticket[name(field)] ?></td><?cs
-    if:idx % 2 ?></tr><tr><?cs
+    if:idx % 2 || fullrow ?></tr><tr><?cs
     elif:idx == num_fields - 1 ?><th></th><td></td><?cs
     /if ?><?cs set:idx = idx + #fullrow + 1 ?><?cs
    /if ?><?cs
@@ -173 +173 @@
   /each ?><?cs set:idx = 0 ?><?cs
    each:field = ticket.fields ?><?cs
     if:!field.skip ?><?cs set:fullrow = field.type == 'textarea' ?><?cs
-     if:fullrow && idx % 2 ?><th class="col2"></th><td></td></tr><tr><?cs /if ?>
+     if:fullrow && idx % 2 ?><?cs set:idx = idx + 1 ?><th class="col2"></th><td></td></tr><tr><?cs /if ?>
      <th class="col<?cs var:idx % 2 + 1 ?>"><?cs
        if:field.type != 'radio' ?><label for="<?cs var:name(field) ?>"><?cs
        /if ?><?cs alt:field.label ?><?cs var:field.name ?><?cs /alt ?>:<?cs
@@ -205 +205 @@
          var:option ?></label> <?cs set:optidx = optidx + 1 ?><?cs
         /each ?><?cs
       /if ?></td><?cs
-     if:idx % 2 ?></tr><tr><?cs
+     if:idx % 2 || fullrow ?></tr><tr><?cs
      elif:idx == num_fields - 1 ?><th class="col2"></th><td></td><?cs
      /if ?><?cs set:idx = idx + #fullrow + 1 ?><?cs
     /if ?><?cs

templates/newticket.cs

@@ -52 +52 @@
   /each ?><?cs set:idx = 0 ?><?cs
    each:field = newticket.fields ?><?cs
     if:!field.skip ?><?cs set:fullrow = field.type == 'textarea' ?><?cs
-     if:fullrow && idx % 2 ?><th class="col2"></th><td></td></tr><tr><?cs /if ?>
+     if:fullrow && idx % 2 ?><?cs set:idx = idx + 1 ?><th class="col2"></th><td></td></tr><tr><?cs /if ?>
      <th class="col<?cs var:idx % 2 + 1 ?>"><?cs
        if:field.type != 'radio' ?><label for="<?cs var:name(field) ?>"><?cs
        /if ?><?cs alt:field.label ?><?cs var:field.name ?><?cs /alt ?>:<?cs
@@ -83 +83 @@
          var:option ?></label> <?cs set:optidx = optidx + 1 ?><?cs
        /each ?><?cs
       /if ?></td><?cs
-     if:idx % 2 ?></tr><tr><?cs
+     if:idx % 2 || fullrow ?></tr><tr><?cs
      elif:idx == num_fields - 1 ?><th class="col2"></th><td></td><?cs
      /if ?><?cs set:idx = idx + #fullrow + 1 ?><?cs
     /if ?><?cs

The rational is that when idx is even, the field is put in col1.

When there's a fullrow field (only textarea for now):

• the previous row is closed if it was only half filled (i.e. idx was odd). idx is then incremented, so that this fullrow field can start in col1 (that's the <?cs set:idx = idx + 1 ?> addition)
• the row is closed after the fullrow (that's the || fullrow change), notwithstanding the fact that the idx is even. The idx will be correctly incremented afterwards (because of the + #fullrow).

[cboos]

Applied previous patch in r2002

[cboos]

... which should close this ticket.

Note that the patches provided by the ticket author apply to an old way of doing the layout of ticket fields: they are not relevant anymore.