Edgewall Software
Modify

Ticket #9125 (reopened enhancement)

Opened 2 years ago

Last modified 20 months ago

Report rendering needs some general overhaul

Reported by: Carsten Klein <carsten.klein@…> Owned by:
Priority: low Milestone: next-major-0.1X
Component: report system Version: 0.12dev
Severity: normal Keywords: patch
Cc:
Release Notes:
API Changes:

Description

When using column_ for breaking the row after the column, everything works fine except that the column has no colspan assigned to extend it across the columns left available to the right.

E.g.

select id, summary as summary_, component, milestone from ticket...

will render both the id and the summary in one line and the rest in the following line.

However, the summary column will only be one column wide whereas it should extend across the available N-1 columns to the right.

Attachments

report_patch.diff (8.0 KB) - added by Carsten Klein <carsten.klein@…> 2 years ago.
patch to both report.py and templates/report_view.py
9125.patch (2.1 KB) - added by Carsten Klein <carsten.klein@…> 2 years ago.
revised patch to report.py

Download all attachments as: .zip

Change History

comment:1 Changed 2 years ago by rblank

  • Resolution set to worksforme
  • Status changed from new to closed

The {row}_ syntax only introduces a line break, not a full line. You're probably looking for the _{row}_ syntax instead. Try:

select id, component, milestone, summary as _summary_ from ticket...

See TracReports for more details.

comment:2 Changed 2 years ago by carsten.klein@…

  • Priority changed from normal to low
  • Resolution worksforme deleted
  • Status changed from closed to reopened
  • Type changed from defect to enhancement

I sure know that it is working, but it would be nicer to have it extend across the remaining columns.

I am currently looking into a patch that would remedy the situation, however, it renders quite complicated to make it work (hidden columns etc.).

I will reopen this as a enhancement request and put it on low.

Changed 2 years ago by Carsten Klein <carsten.klein@…>

patch to both report.py and templates/report_view.py

comment:3 follow-up: Changed 2 years ago by Carsten Klein <carsten.klein@…>

the presented patch remedies the situation that

  • under certain conditions empty table rows are being rendered (e.g. id as _ticket_ as the second column after ... as color or inbetween)
  • all columns that are considered fullrows will now extend not to a standard of 100 columns but to the actual number of available (visible) columns
  • all columns that cause a row break will now also extend across the remainder of the columns to the right
  • each row in a row_group will be in a separate table body (discussable)

all in all this should provide for nicer renderings of ticket reports

comment:4 in reply to: ↑ 3 Changed 2 years ago by Carsten Klein <carsten.klein@…>

Replying to Carsten Klein <carsten.klein@…>:

additionally

  • outcommented the <hr> in case of a fullrow
  • fullrow cells will now have the correct class name, e.g. summary and not fullrow

comment:5 Changed 2 years ago by rblank

  • Keywords patch added
  • Milestone set to next-minor-0.12.x

Thanks for the patch.

comment:6 Changed 2 years ago by Carsten Klein <carsten.klein@…>

  • Summary changed from Using as column_ to break the row after the column does not colspan the column to Report rendering needs some general overhaul

Changed 2 years ago by Carsten Klein <carsten.klein@…>

revised patch to report.py

comment:7 Changed 2 years ago by Carsten Klein <carsten.klein@…>

the previous patch to report.py rendered the view unusable (i.e. it missed inclusion of ticket id when id was rendered as a fullrow, e.g. id as _ticket_),

comment:8 Changed 2 years ago by Carsten Klein <carsten.klein@…>

possible regression here still: user does not include ticket.id in query

result would be that all tickets in the report will not be navigateable.

perhaps we should introduce the ticket id as a mandatory requirement for reports?

comment:9 Changed 20 months ago by cboos

  • Milestone changed from next-minor-0.12.x to next-major-0.1X
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as reopened
as The resolution will be set. Next status will be 'closed'
to The owner will be changed from (none). Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.