Edgewall Software
Modify

Ticket #907 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Closing font-style tags ('', ''', ~~ and __) are not recognized around an intra-trac link

Reported by: Juanma Barranquero Owned by: jonas
Priority: low Milestone: 0.8
Component: wiki system Version: devel
Severity: minor Keywords: patch
Cc:
Release Notes:
API Changes:

Description (last modified by cmlenz) (diff)

Wiki links like

'''ticket:1'''

incorrectly generate HTML links like this one:

<strong><a title="" class="missing" href="/trac/ticket/1'''">ticket:1'''?</a></strong>

I'm no expertin WikiFormatter.py, but the attached patch seems to fix the problem.

Attachments

WikiFormatter.diff (732 bytes) - added by Juanma Barranquero 8 years ago.
Patch to fix intra-trac links inside font styles.
ticket907.patch (1.6 KB) - added by cmlenz 8 years ago.
Combined patch with additional unit test

Download all attachments as: .zip

Change History

Changed 8 years ago by Juanma Barranquero

Patch to fix intra-trac links inside font styles.

Changed 8 years ago by cmlenz

Combined patch with additional unit test

comment:1 Changed 8 years ago by cmlenz

  • Component changed from general to wiki
  • Description modified (diff)
  • Keywords patch added; links removed
  • Priority changed from normal to low

I think the patch looks good, and have just added a new patch including the original but with an added unit test for the expected behavior.

I'll leave it to jonas to actually check in this change, as I'm far too uncertain about touching the Wiki formatter myself at this point.

comment:2 Changed 8 years ago by jonas

  • Status changed from new to assigned

ok, I'll take a look…

comment:3 Changed 8 years ago by jonas

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [1045], thanks!

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from jonas. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.