Ticket #878 (closed defect: fixed)
Opened 7 years ago
Last modified 7 years ago
Field "resolution" is disabled incorrectly on Advanced Query screen
| Reported by: | pkou <pkou at ua.fm> | Owned by: | cmlenz |
|---|---|---|---|
| Priority: | low | Milestone: | 0.8 |
| Component: | ticket system | Version: | devel |
| Severity: | minor | Keywords: | query |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
Filtering tickets by field Resolution depends on the statuses that are selected by user in field Status. This is because field resolution is empty when a ticket has status new, assigned, or reopened.
Current implementation enables field Resolution if no statuses are selected or when status closed is selected. This is incorrect because when user selects closed and other status like new, the field Resolution is still enabled, and using it leads to empty screens.
Proposed implementation: Enable field Resolution if no statuses are selected or statuses new, assigned, and reopened are not selected.
Patch attached.
Attachments
Change History
Changed 7 years ago by pkou <pkou at ua.fm>
- Attachment patch-queryres-r1014.diff added
comment:1 Changed 7 years ago by cmlenz
- Component changed from report system to ticket system
- Keywords query added
- Milestone set to 0.8
- Owner changed from daniel to cmlenz
- Priority changed from normal to low
- Severity changed from normal to minor
- Status changed from new to assigned
Good catch.
I'd like to avoid hardcoding the resolution names in the script. If we can depend on the order of the status values (which pretty much is a given in the current codebase), a simple check for selectedIndex >= 3 should be enough, and more compact.
comment:2 Changed 7 years ago by cmlenz
- Resolution set to fixed
- Status changed from assigned to closed
Fixed in [1017].
Patch for the defect