Ticket #85 (closed defect: fixed)
Opened 8 years ago
Last modified 6 years ago
Descriptive svn: links generate different links than standard svn: links.
| Reported by: | mrowe@… | Owned by: | jonas |
|---|---|---|---|
| Priority: | highest | Milestone: | 0.5.2 |
| Component: | wiki system | Version: | 0.5.1 |
| Severity: | minor | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
When a link is created of the form svn:/aDirectory/ the link points to /log/aDirectory/. When the link is created as [svn:/aDirectory/ Description] the link points to /file/aDirectory/. This is problematic when /aDirectory/ is a directory as Trac attempts to retrieve the locations length from Subversion, generating an error.
This is caused by the fact that the fancysvnhref regular expression is listed after the more generic fancylink in svn:/trunk/trac/Wiki.py. Changing the order of the two regular expressions fixes the problem.
Attachments
Change History
comment:1 Changed 8 years ago by anonymous
comment:2 Changed 8 years ago by daniel
- Priority changed from normal to highest
- Severity changed from normal to blocker
comment:3 Changed 8 years ago by jonas
- Status changed from new to assigned
comment:4 Changed 8 years ago by jonas
- Resolution set to fixed
- Status changed from assigned to closed
Probably fixed in [195]. Please reopen this ticket if it's still broken.
The new behavour is as follows:
svn:/path and [svn:/path description]
both creates a link to trac.cgi/browser/path. The browser module will then display the directory contents, but the user will be redirected to
trac.cgi/file/path if path points to a file instead of a directory.
comment:5 Changed 8 years ago by mrowe@…
- Resolution fixed deleted
- Severity changed from blocker to minor
- Status changed from closed to reopened
Changeset [195] fixes the problem that I reported, but I am unsure whether redirecting to trac.cgi/file/path when path is a file is desirable behaviour. It makes more sense in my mind to redirect to trac.cgi/log/path in that case, as this allows the user to view either the file's contents or the changeset if they so desire.
comment:6 Changed 8 years ago by jonas
- Resolution set to fixed
- Status changed from reopened to closed
Fixed in [196].
Yes you are right. The new behaviour is as follows:
File links are now redirected to the log module unless a specific file revision
is requested.
svn:/path/file will display the file log
svn:/path/file#rev will display the file contens for that revision.
comment:7 Changed 6 years ago by cboos
Note that in 0.9 (and in 0.8 also, I'm pretty sure),
the svn: prefix has no special meaning anymore:
- svn:/trunk
- svn:/trunk/README
Use source: prefix instead (browser: and repos: are also supported)



Apologies for the bad formatting of the report.