Edgewall Software
Modify

Ticket #8444 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Enhance author display on Trac's plugin admin panel

Reported by: sebastian@… Owned by: sebastian@…
Priority: normal Milestone: 0.11.6
Component: admin/web Version: 0.11.4
Severity: normal Keywords: patch
Cc:
Release Notes:
API Changes:

Description

I find the behavior of Trac's plugin panel displaying information about the author(s) of a plugin a little bit strange. This field can be seen when browsing to Admin -> General -> Plugins and expanding an installed plugin.

First of all, it never displays the author's name (at least not when using easy_install to install a plugin from a Subversion repository). The reason is:

  • If I provide an email address for my plugin (provided in setup.py under author_email and later in EGG-INFO/PKG-INFO under Author-email) the plugin panel will always use the email adress and never the author's name.
  • If I don't provide an email address, easy_install will fill the field in PKG-INFO with the value UNKNOWN. Therefor it's not None and the plugin panel displays UNKNOWN (instead of the author's name, if provided).

Furthermore the plugin panel doesn't work with author names containing a non-ASCII character as in "Radek Bartoň". This is because Trac's plugin panel doesn't convert author names to unicode.

I've attached a patch that fixes all these problems. I'm not sure whether this is a defect or an enhancement. But my guess is that this behavior was not intended so I file this as "defect".

Btw: I'm using Python 2.6 with setup_tools 0.6c9.

Attachments

plugin-panel-author-name.patch (1.7 KB) - added by sebastian@… 3 years ago.
Patch against Trac 0.11.x

Download all attachments as: .zip

Change History

Changed 3 years ago by sebastian@…

Patch against Trac 0.11.x

comment:1 Changed 3 years ago by rblank

  • Keywords patch added
  • Milestone set to 0.11.6
  • Owner set to rblank

Thanks for the patch!

comment:2 Changed 3 years ago by rblank

  • Resolution set to fixed
  • Status changed from new to closed

Patch works great, applied in [8424]. Thanks!

comment:3 Changed 3 years ago by rblank

  • Owner changed from rblank to sebastian@…
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from sebastian@…. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.