Edgewall Software
Modify

Opened 15 years ago

Last modified 8 years ago

#8219 new enhancement

[PATCH] Forward additional parameters from /report to /query

Reported by: thomas.moschny@… Owned by:
Priority: normal Milestone: next-major-releases
Component: report system Version: 0.11-stable
Severity: normal Keywords: patch saved queries bitesized
Cc: jaya.kirtani@…, Ryan J Ollos Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Calling an URL like this

http://myserver.example/trac/report/10

redirects to

http://myserver.example/trac/query?col=x&status=new&...&report=10

Now, it would be nice, if additional parameters could be passed to the (short) report URL and not be forgotten while redirecting to the query, e.g.

http://myserver.example/trac/report/10?format=csv&col=description

would redirect to

http://myserver.example/trac/query?col=x&status=new&...&col=description&report=10&format=csv

Ideally, these parameters would be given precedence over those from the report definition (where applicable - i.e. col parameters would simply be added, like in the example).

Attachments (2)

patch_8219.diff (2.3 KB ) - added by Jaya Kirtani <jaya.kirtani@…> 11 years ago.
updated_patch_8219.diff (2.3 KB ) - added by Jaya Kirtani <jaya.kirtani@…> 11 years ago.
Updated patch to fix coding style issues

Download all attachments as: .zip

Change History (11)

comment:1 by Christian Boos, 15 years ago

Keywords: saved queries added
Milestone: 0.13

Good idea (and a patch do wonders to get a closer milestone…)

comment:2 by Remy Blank, 14 years ago

Keywords: bitesized added

by Jaya Kirtani <jaya.kirtani@…>, 11 years ago

Attachment: patch_8219.diff added

comment:3 by Jaya Kirtani <jaya.kirtani@…>, 11 years ago

Cc: jaya.kirtani@… added
Summary: Forward additional parameters from /report to /query[PATCH] Forward additional parameters from /report to /query

Above attached patch updates the code to forward the additional parameters from /report to /query. The patch adds unit test case to test the same. Also verified that the change passes the existing unit and functional test cases.

comment:4 by Christian Boos, 11 years ago

Thanks for the patch! But a rapid look shows you didn't read the patch guidelines (e.g. PatchWelcome and the links there)…

comment:5 by Jaya Kirtani <jaya.kirtani@…>, 11 years ago

I did look at the patch guidelines. After again looking at the patch I could find a couple of places where spaces are missing.Can you please mention if there is anything specific?

by Jaya Kirtani <jaya.kirtani@…>, 11 years ago

Attachment: updated_patch_8219.diff added

Updated patch to fix coding style issues

comment:6 by Jaya Kirtani <jaya.kirtani@…>, 11 years ago

Made following changes :

  1. Added missing spaces (for assignment operator etc)
  2. Replaced "" with for string constants.

Please let me know if I missed anything else.

comment:7 by Ryan J Ollos, 10 years ago

Cc: Ryan J Ollos added

comment:8 by Ryan J Ollos, 10 years ago

This could help with the request in th:#8030 as well. Rather than allowing batch modify on the report page, the user could easily navigate to the query page to batch modify the tickets.

comment:9 by figaro, 8 years ago

Keywords: patch added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.