Edgewall Software

Ticket #789 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[merge] cleanup scrollbar_position

Reported by: tonib Owned by: cmlenz
Priority: low Milestone: 0.8
Component: wiki system Version: 0.7.1
Severity: minor Keywords:
Cc:

Description (last modified by cmlenz) (diff)

Added patch that cleans up the scroll_bar_position code in wiki.cs a little bit more. It also worked in IE under Wine.

Best regards,

Toni

Attachments

patch.diff (3.0 KB) - added by tonib 4 years ago.

Change History

Changed 4 years ago by tonib

Changed 4 years ago by cmlenz

  • owner changed from jonas to cmlenz

Changed 4 years ago by cmlenz

  • status changed from new to assigned

Changed 4 years ago by cmlenz

  • milestone set to 0.8

If I read the patch correctly, it also removes support for setting the selection start/end in Gecko-based browsers. Why?

Changed 4 years ago by tonib

Since when doing preview you will set focus on the preview text. This means that the selection text will be dissappear. And when you click on the textarea it the selection doesnt exist anymore. So no reason to have it, since it doesnt work.

Changed 4 years ago by tonib

If one wants to keep the selection start/end code. I think the proper way of doing it is to use the javascript function onFocus and onBlur to save and reload the cursor setting. In addtion saving it when doing preview.

/T

Changed 4 years ago by cmlenz

Just a note: the selection is preserved on Mozilla-based browsers even if we pass focus to the preview. It's just that you need to tab back into <textarea></textarea> instead of clicking in it, as the latter will indeed reset the selection range.

Maybe we should remove the jump to the preview anchor after all?

Changed 4 years ago by cmlenz

  • status changed from assigned to closed
  • description modified (diff)
  • component changed from general to wiki
  • priority changed from normal to low
  • resolution set to fixed
  • severity changed from normal to minor

Fixed in [994].

Add/Change #789 ([merge] cleanup scrollbar_position)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cmlenz. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.