Opened 20 years ago
Closed 20 years ago
#789 closed defect (fixed)
[merge] cleanup scrollbar_position
| Reported by: | tonib | Owned by: | Christopher Lenz |
|---|---|---|---|
| Priority: | low | Milestone: | 0.8 |
| Component: | wiki system | Version: | 0.7.1 |
| Severity: | minor | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
Added patch that cleans up the scroll_bar_position code in wiki.cs a little bit more. It also worked in IE under Wine.
Best regards,
Toni
Attachments (1)
Change History (8)
by , 20 years ago
| Attachment: | patch.diff added |
|---|
comment:1 by , 20 years ago
| Owner: | changed from to |
|---|
comment:2 by , 20 years ago
| Status: | new → assigned |
|---|
comment:3 by , 20 years ago
| Milestone: | → 0.8 |
|---|
comment:4 by , 20 years ago
Since when doing preview you will set focus on the preview text. This means that the selection text will be dissappear. And when you click on the textarea it the selection doesnt exist anymore. So no reason to have it, since it doesnt work.
comment:5 by , 20 years ago
If one wants to keep the selection start/end code. I think the proper way of doing it is to use the javascript function onFocus and onBlur to save and reload the cursor setting. In addtion saving it when doing preview.
/T
comment:6 by , 20 years ago
Just a note: the selection is preserved on Mozilla-based browsers even if we pass focus to the preview. It's just that you need to tab back into <textarea></textarea> instead of clicking in it, as the latter will indeed reset the selection range.
Maybe we should remove the jump to the preview anchor after all?
comment:7 by , 20 years ago
| Component: | general → wiki |
|---|---|
| Description: | modified (diff) |
| Priority: | normal → low |
| Resolution: | → fixed |
| Severity: | normal → minor |
| Status: | assigned → closed |
Fixed in [994].
If I read the patch correctly, it also removes support for setting the selection start/end in Gecko-based browsers. Why?