Edgewall Software
Modify

Ticket #7801 (closed defect: fixed)

Opened 21 months ago

Last modified 21 months ago

0.11.2 wiki error: NameError: global name 'set' is not defined

Reported by: pmoura@… Owned by: rblank
Priority: normal Milestone: 0.11.2
Component: wiki system Version: 0.11.2
Severity: blocker Keywords:
Cc:

Description (last modified by rblank) (diff)

Hi!

I've just update a 0.11.1 installation ( http://trac.logtalk.org) to 0.11.2. No problems with the update. However, accessing most of the wiki pages linked from the home page gives the error:

`NameError: global name 'set' is not defined`

In the log file I found the following entry:

    self._sanitizer = TracHTMLSanitizer()
  File "/home/.purrmethius/pmoura/trac/lib/python2.3/site-packages/Trac-0.11.2-py2.3.egg/trac/util/html.py", line 29, in __init__
    safe_attrs = HTMLSanitizer.SAFE_ATTRS | set(['style'])
NameError: global name 'set' is not defined

Thanks for developing great software. Best regards,

Paulo

Attachments

Change History

comment:1 Changed 21 months ago by pmoura@…

Searching the web for the error message, it seems the problem is related to the use of Python 2.3. Adding the following line to the trac/util/html.py file (around line 20) seems to solve the problem:

from sets import Set as set

comment:2 Changed 21 months ago by rblank

  • Owner set to rblank
  • Description modified (diff)

Wow, that was quick... It is a bit unfortunate that this has crept in right before the release. I hope that there are not too many Trac users who still run on Python 2.3.

Anyway, it's fixed in 0.11-stable in [7667]. Thanks for the bug report. Did you have any other problems with 0.11.2 related to Python 2.3? Ideally, we should have a 2.3 build host for 0.11-stable, but I think this will be difficult.

What's the policy for such a "blocker" issue (for 2.3)? Should we tell people to install from SVN, or do we re-tag and update the release tarballs?

comment:3 Changed 21 months ago by pmoura@…

So far I've not detected any other problems in using Trac 0.11.2 with Python 2.3 but I only performed limited testing.

comment:4 Changed 21 months ago by rblank

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone set to 0.11.2

This fix has been released as 0.11.2.1.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from rblank. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.