Edgewall Software
Modify

Ticket #7705 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

unit test failure with pygments 0.11.1dev

Reported by: cboos Owned by: thatch
Priority: normal Milestone: 0.11.2
Component: rendering Version: 0.11-stable
Severity: normal Keywords: pygments
Cc:
Release Notes:
API Changes:

Description

Using pygments:56c3e7e93e27 (latest tip in pygments-main as of today), I get the following failure in Trac's unit tests:

FAIL: test_newline_content (trac.mimeview.tests.pygments.PygmentsRendererTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Workspace\src\trac\repos\trunk\trac\mimeview\tests\pygments.py", line 103, in test_newline_content
    self.assertEqual("\n\n\n", t)
AssertionError: '\n\n\n' != u'\n\n\n\n'

Looking at the code, it seems that u'\n\n\n\n' should actually be the more correct result and that '\n\n\n' was the sub-optimal result we had up to now.

Tim, could you please look at this and eventually add a kind of version check to the test?

Attachments

Change History

comment:1 Changed 3 years ago by thatch

  • Status changed from new to assigned

I haven't checked yet, but this is most likely caused by http://dev.pocoo.org/projects/pygments/changeset/a471fde4e814

I'll update later today.

comment:2 Changed 3 years ago by thatch

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r7607

comment:3 Changed 3 years ago by cboos

  • Milestone changed from 0.11-retriage to 0.11.2

Backported to 0.11-stable in [7616].

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from thatch. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.