[header_logo] src and [project] icon does not use htdocs_location

[cat@…]

I have following lines in trac.ini

[header_logo]
src = trac_banner.png

[project]
icon = trac.ico

[trac]
htdocs_location = /trac/

And I get in HTML lines like these

<link rel="shortcut icon" href="/trac.cgi/chrome/common/trac.ico" type="image/x-icon" />
<link rel="icon" href="/trac.cgi/chrome/common/trac.ico" type="image/x-icon" />
...
<img src="/trac.cgi/chrome/common/trac_banner.png" ...

I assume they should be relative to htdocs_location as well as other static content.

[mail@…]

I can confirm this. 0.11 on Gentoo.

Tried to fix it like this:

/usr/lib64/python2.5/site-packages/trac/templates/theme.html

@@ -17 +17 @@
     <div id="banner">
       <div id="header" py:choose="">
         <a py:when="chrome.logo.src" id="logo" href="${chrome.logo.link or href.wiki('TracIni')+'#header_logo-section'}"><img
-          src="${chrome.logo.src}" alt="${chrome.logo.alt}"
+          src="${chrome.htdocs_location}${chrome.logo.src}" alt="${chrome.logo.alt}"
           height="${chrome.logo.height or None}" width="${chrome.logo.width or None}" /></a>
         <h1 py:otherwise=""><a href="${chrome.logo.link}">${project.name}</a></h1>
       </div>

The result was an URL like /project/trac-htdocs//project/trac/chrome/common/site/mylogo.png. What I expected it to be: /project/trac-htdocs/chrome/common/site/mylogo.png.

Related config snippets:

[trac]
htdocs_location = /project/trac-htdocs

[header_logo]
src = site/mylogo.png

Maybe someone else knows how to do the fix correctly.

[osimons]

You'll want to look at #6562 as that is closely related - and your expected behaviour is even noted as a possible #TODO on the ticket and in the source.

The simple workaround is to use an absolute or server-relative URL for the logo - like /myhtdocs/mylogo.png. That logo source variable will be used as-is by the template.