Edgewall Software
Modify

Ticket #742 (closed defect: fixed)

Opened 8 years ago

Last modified 6 years ago

Hitting preview when comment is empty breaks trac

Reported by: anonymous Owned by: jonas
Priority: normal Milestone: 0.8
Component: wiki system Version: devel
Severity: normal Keywords:
Cc: jonas@…
Release Notes:
API Changes:

Description

Steps to reproduce: select a ticket, select "reassign ticket to", enter a name, hit "preview" instead of submit.

Result:

 Trac detected an internal error:

  'NoneType' object has no attribute 'splitlines'

Traceback:

 Traceback (most recent call last):
  File "/usr/lib/python2.2/site-packages/trac/core.py", line 522, in cgi_start
    real_cgi_start()
  File "/usr/lib/python2.2/site-packages/trac/core.py", line 517, in real_cgi_start
    dispatch_request(path_info, args, req, env)
  File "/usr/lib/python2.2/site-packages/trac/core.py", line 432, in dispatch_request
    module.run()
  File "/usr/lib/python2.2/site-packages/trac/Module.py", line 45, in run
    self.render()
  File "/usr/lib/python2.2/site-packages/trac/Ticket.py", line 442, in render
    self.req.hdf, self.env))
  File "/usr/lib/python2.2/site-packages/trac/WikiFormatter.py", line 536, in wiki_to_html
    Formatter(hdf, env, absurls).format(wikitext, out)
  File "/usr/lib/python2.2/site-packages/trac/WikiFormatter.py", line 490, in format
    for line in text.splitlines():
AttributeError: 'NoneType' object has no attribute 'splitlines'

Attachments

Change History

comment:1 Changed 8 years ago by anonymous

  • Summary changed from Hitting preview button when reassigning a ticket breaks track to Hitting preview when comment is empty breaks trac

On further investigation it seems that this will happen whenever the comment field is left empty and preview is selected. I've updated the summary to reflect this.

comment:2 Changed 8 years ago by Matthew Good <matt-good.net>

  • Component changed from ticket system to wiki
  • Milestone set to 0.8
  • Version changed from 0.7.1 to devel

Well, I'm changing the version to "devel", as WikiFormatter?.py isn't in milestone:0.7.1 and changing the component to wiki, as that's where the problem seems to originate from.

However, I'm using the trunk from [909] and I can't reproduce this error. I'm using mod_python, though so the problem could be cgi specific.

comment:3 Changed 8 years ago by jonas

  • Status changed from new to assigned

comment:4 Changed 8 years ago by jonas

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [912].

comment:5 Changed 8 years ago by jonas

  • Cc jonas@… added

test

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from jonas. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.