Opened 5 years ago
Closed 4 years ago
#7386 closed defect (fixed)
Trac fails on URIs
| Reported by: | erlehmann | Owned by: | cboos |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | wiki system | Version: | |
| Severity: | normal | Keywords: | traclinks review |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
Look at this link: <http://en.wikipedia.org/wiki/Mornington_Crescent_(game)> - it isn't highlighted correctly - the last bracket should be part of the URI. Now take <xmpp:erlehmann@jaim.at?roster> or <urn:isbn:0-345-33971-1>, which aren't highlighted at all.
A detailed solution with a proper regex that also matches links in parentheses can be found at <http://dieweltistgarnichtso.net/index.php?/archives/32-Constructing-a-regular-expression-that-matches-URIs.html#extended> .
Attachments (1)
Change History (5)
comment:1 in reply to: ↑ description Changed 5 years ago by rblank
- Milestone set to 1.0
comment:2 Changed 5 years ago by cboos
- Component changed from web frontend to wiki system
- Keywords traclinks added
- Milestone changed from 1.0 to 0.12
- Owner set to cboos
Strange that I didn't write anything on the ticket, as I have implemented it a while back after reading this ticket (or was it a duplicate?)
comment:3 Changed 5 years ago by cboos
- Keywords review added
- Status changed from new to assigned
No, the patch was actually targeting this ticket, sorry for not answering earlier.
comment:4 Changed 4 years ago by cboos
- Resolution set to fixed
- Status changed from assigned to closed
Patch applied in r8696.
Replying to erlehmann:
And I actually clicked on the link, and thought "wtf?" :-)
We could indeed do better than the current state.