Edgewall Software
Modify

Ticket #7386 (closed defect: fixed)

Opened 2 years ago

Last modified 9 months ago

Trac fails on URIs

Reported by: erlehmann Owned by: cboos
Priority: normal Milestone: 0.12
Component: wiki system Version:
Severity: normal Keywords: traclinks review
Cc:

Description

Look at this link: < http://en.wikipedia.org/wiki/Mornington_Crescent_(game)> - it isn't highlighted correctly - the last bracket should be part of the URI. Now take <xmpp:erlehmann@jaim.at?roster> or <urn:isbn:0-345-33971-1>, which aren't highlighted at all.

A detailed solution with a proper regex that also matches links in parentheses can be found at < http://dieweltistgarnichtso.net/index.php?/archives/32-Constructing-a-regular-expression-that-matches-URIs.html#extended> .

Attachments

t7386-alt-shref-r7606.diff Download (2.5 KB) - added by cboos 22 months ago.
Add alternative syntax for short links: <realm_or_protocol:target>

Change History

comment:1 in reply to: ↑ description Changed 22 months ago by rblank

  • Milestone set to 1.0

Replying to erlehmann:

Look at this link: (...)

And I actually clicked on the link, and thought "wtf?" :-)

We could indeed do better than the current state.

comment:2 Changed 22 months ago by cboos

  • Keywords traclinks added
  • Owner set to cboos
  • Component changed from web frontend to wiki system
  • Milestone changed from 1.0 to 0.12

Strange that I didn't write anything on the ticket, as I have implemented it a while back after reading this ticket (or was it a duplicate?)

Changed 22 months ago by cboos

Add alternative syntax for short links: <realm_or_protocol:target>

comment:3 Changed 22 months ago by cboos

  • Keywords review added
  • Status changed from new to assigned

No, the patch was actually targeting this ticket, sorry for not answering earlier.

comment:4 Changed 9 months ago by cboos

  • Status changed from assigned to closed
  • Resolution set to fixed

Patch applied in r8696.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cboos. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.