Edgewall Software

Ticket #7293 (closed enhancement: fixed)

Opened 13 months ago

Last modified 7 months ago

support for dynamic variables in the report_view page

Reported by: andrei2102@… Owned by: rblank
Priority: normal Milestone: 0.12
Component: report system Version:
Severity: normal Keywords: dynamicvar patch
Cc: scratcher@…

Description

After the discussion on this  trac-dev thread I made a patch that displays a list of filters for every variable in a query.

The problem this patch resolves is encountered when a sql report has a variable defined and no values is passed in the URL. The patch allows the user to enter values for this variables.

Attachments

dynamic_variables.diff Download (4.7 KB) - added by andrei2102@… 13 months ago.
7293-report-argument-editor-r7493.patch Download (5.8 KB) - added by rblank 11 months ago.
Patch against 0.11-stable adding editable fields for report arguments
trac-report_args.diff Download (0.6 KB) - added by catalin.balan@… 7 months ago.
Enabling dynamic report arguments form for reports with only one argument
trac-report_args.2.diff Download (0.6 KB) - added by catalin.balan@… 7 months ago.
hidding the form for args.keys()==USER?

Change History

Changed 13 months ago by andrei2102@…

Changed 11 months ago by rblank

Patch against 0.11-stable adding editable fields for report arguments

  Changed 11 months ago by rblank

  • keywords patch added
  • owner changed from mgood to rblank

The patch above is a rework of the first patch attached (which was already very good):

  • The layout of the argument fieldset was adapted to be as close to the custom query as possible.
  • A warning lists missing arguments (if any).
  • The folding JavaScript is not called if there are no arguments.

Fields are considered missing if they don't appear in the request at all. Empty arguments are considered present.

Comments?

  Changed 10 months ago by anonymous

  • cc scratcher@… added

  Changed 9 months ago by rblank

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 0.12

Patch applied in [7555], with a few fixes to report test cases, and an additional test case for missing arguments.

Changed 7 months ago by catalin.balan@…

Enabling dynamic report arguments form for reports with only one argument

follow-up: ↓ 5   Changed 7 months ago by catalin.balan@…

Hi,

Is there a reason why only reports with len(args)>1 should have the dynamic arguments form ? Check out the previous attached patch.

Sorry for the double post

Thank you, Catalin Balan

in reply to: ↑ 4   Changed 7 months ago by rblank

Replying to catalin.balan@…:

Is there a reason why only reports with len(args)>1 should have the dynamic arguments form ?

IIRC, there is always at least one argument, for the automatic $USER variable. So len(args) is always at least 1. It is >1 only when there are custom arguments.

Do you actually observe that the form is missing for a report with a single custom argument? I may have missed something.

Changed 7 months ago by catalin.balan@…

hidding the form for args.keys()==USER?

  Changed 7 months ago by catalin.balan@…

Hey rblank,

AFAIK, there is also a method that clear args that are not used in the sql, so for queries that are using only one var, other then USER, the form is not showed.

Thank you, Catalin Balan

  Changed 7 months ago by rblank

  • status changed from closed to reopened
  • resolution fixed deleted

Ok, I'll check that.

  Changed 7 months ago by rblank

  • status changed from reopened to closed
  • resolution set to fixed

Right, I wasn't careful enough. Fixed in [7756]. Thanks for reporting the issue.

Add/Change #7293 (support for dynamic variables in the report_view page)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from rblank. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.