Add navigation (prev/next revision) to repo browser

[res@…]

This adds two navigation links to the source browser to quickly get to the previous or next revision of a file.

[res@…]

Patch to add navigation for repo browser

[cboos]

Looks good.

[rblank]

I'll test and apply.

[rblank]

Improved version of the first patch.

[rblank]

The patch above is an improved version of the first patch:

• Use node.rev to determine previous and next revision, instead of rev_or_latest.
• Don't display a "Next Revision" link when already at the latest revision.
• Added arrows.

However, it has the following caveats (that were already present in the original patch):

• Using repos.prev_rev() and repo.next_rev() doesn't work well for directories, so the links are only shown for files. Making it work for directories would require using the same logic as in the revision log, and even then, would only allow going back in time, not forward (the same as in the log). I feel this is too much complication for the added value.

• repos.prev_rev() doesn't follow copies. I could probably add some logic for that, but I'm not sure it's worth the effort.

Thoughts?

[cboos]

I think we can live with the proposed implementation and the caveats above (the TracBrowser interface can always be improved later, especially when the rev navigation logic itself gets improved).

But can we have a way to see:

<- Previous Revision | Revision Log | Next Revision ->

so that it matches what we have when looking at specific versions of wiki pages or tickets?

[rblank]

Replying to cboos:

But can we have a way to see:

Sure, actually that's what the original patch was doing. I couldn't find a place where we had the same situation (previous and next links, and other links in-between), so I settled for keeping the links that are always present always at the same location (on the right). But better be consistent.

[rblank]

Mmh, the wiki pages actually have the following:

<- Previous Version | View Latest Version | Next Version -> | Last Change

How about using prevnext_nav(), like we do for wiki pages? Patch coming up shortly.

[rblank]

Improved version using prevnext_nav().

[rblank]

Last patch applied in [8745], the navigation is consistent with wiki pages.

[Ryan Ollos <ryano@…>]

Hello,

I was looking at the changes you made, and because you merged this into the trunk I was expecting that if I navigated to a file such as browser:trunk/trac/versioncontrol/web_ui/browser.py​, I would be able to see the prev/latest/next revision links.

I was assuming that this Trac site was running off the trunk. Is that not the case?

• Ryan

[rblank]

No, it's running 0.11-stable (r8631 at the moment).