Edgewall Software

Changes between Initial Version and Version 1 of Ticket #7106, comment 4


Ignore:
Timestamp:
Jul 10, 2018, 2:13:01 AM (6 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7106, comment 4

    initial v1  
    77This call (sending a 304 response) may allow the browser to show a previously cached page, which might contains the outdated timestamp.
    88
    9 But if [source:trunk/trac/versioncontrol/templates/changeset_content.html@:188-201 something like this] would also be added to [source:trunk/trac/templates/attachment.html@6980:83#L76 the attachment template], then "84 seconds ago" would be shown as "less than one hour ago" instead. So the cached page wouldn't instantly become obsolete.
     9But if [source:trunk/trac/versioncontrol/templates/changeset_content.html@:188-201#L185 something like this] would also be added to [source:trunk/trac/templates/attachment.html@6980:83#L76 the attachment template], then "84 seconds ago" would be shown as "less than one hour ago" instead. So the cached page wouldn't instantly become obsolete.
    1010
    1111To ensure the browser stops using the cached page once it does become obsolete, [source:trunk/trac/versioncontrol/web_ui/changeset.py@6980:295#L291 pretty_timedelta(..., 3600)] (resolution of 3600 seconds i.e. one hour) would be added to that `check_modified` call.