Edgewall Software

Ticket #6765 (closed enhancement: fixed)

Opened 6 months ago

Last modified 3 weeks ago

Make language select a preference choice

Reported by: jruigrok Owned by: jruigrok
Priority: normal Milestone: 0.12
Component: i18n Version: devel
Severity: normal Keywords: i18n l10n
Cc: Zoom.Quiet@…, jasminlapalme@…

Description

Right now we only use Accept-Language to negotiate the language, but we will need to add a choice in the preferences as well to allow people to set the language using a cookie.

Attachments

i18n_r6891_language_select.patch (2.0 kB) - added by jasminlapalme@… 3 months ago.

Change History

Changed 6 months ago by jruigrok

  • component changed from general to i18n

Changed 4 months ago by jruigrok

  • status changed from new to assigned

Changed 4 months ago by jruigrok

Committed a first version on the i18n sandbox in r6732.

Changed 4 months ago by jruigrok

The only problem in the code is that it does not seem to switch languages. Cursory read-throughs by Alec (aat) and Christopher (cmlenz) indicate that the idea is good.

Changed 3 months ago by Zoom.Quiet <Zoom.Quiet@…>

  • cc Zoom.Quiet@… added

when will move as trunk?

Changed 3 months ago by jruigrok

Well, as soon as 0.11 is released.

Changed 3 months ago by jasminlapalme@…

Changed 3 months ago by jasminlapalme@…

I did a patch to make it work. Well it work for me.

Changed 3 months ago by jasminlapalme@…

  • cc jasminlapalme@… added

Changed 3 months ago by jruigrok

Committed in r6929. Thanks.

Seems it has one minor nit with regard to the default language. By the way, if I spelled your name wrong, let me know, I went with Jasmin Lapalme right now.

Changed 3 months ago by jasminlapalme@…

You spell it right.

The default language seems to be the language of the browser.

Changed 3 weeks ago by jruigrok

  • status changed from assigned to closed
  • resolution set to fixed

This is in place for 0.12 in trunk for a while. Double checked the default language working, it indeed defaults to the browser setup.

Add/Change #6765 (Make language select a preference choice)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.