Ticket #6765 (closed enhancement: fixed)
Opened 4 years ago
Last modified 4 years ago
Make language select a preference choice
| Reported by: | jruigrok | Owned by: | jruigrok |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | i18n | Version: | devel |
| Severity: | normal | Keywords: | i18n l10n |
| Cc: | Zoom.Quiet@…, jasminlapalme@… | ||
| Release Notes: | |||
| API Changes: | |||
Description
Right now we only use Accept-Language to negotiate the language, but we will need to add a choice in the preferences as well to allow people to set the language using a cookie.
Attachments
Change History
comment:1 Changed 4 years ago by jruigrok
- Component changed from general to i18n
comment:2 Changed 4 years ago by jruigrok
- Status changed from new to assigned
comment:3 Changed 4 years ago by jruigrok
comment:4 Changed 4 years ago by jruigrok
The only problem in the code is that it does not seem to switch languages. Cursory read-throughs by Alec (aat) and Christopher (cmlenz) indicate that the idea is good.
comment:5 Changed 4 years ago by Zoom.Quiet <Zoom.Quiet@…>
- Cc Zoom.Quiet@… added
when will move as trunk?
comment:6 Changed 4 years ago by jruigrok
Well, as soon as 0.11 is released.
Changed 4 years ago by jasminlapalme@…
- Attachment i18n_r6891_language_select.patch added
comment:7 Changed 4 years ago by jasminlapalme@…
I did a patch to make it work. Well it work for me.
comment:8 Changed 4 years ago by jasminlapalme@…
- Cc jasminlapalme@… added
comment:9 Changed 4 years ago by jruigrok
Committed in r6929. Thanks.
Seems it has one minor nit with regard to the default language.
By the way, if I spelled your name wrong, let me know, I went with Jasmin Lapalme right now.
comment:10 Changed 4 years ago by jasminlapalme@…
You spell it right.
The default language seems to be the language of the browser.
comment:11 Changed 4 years ago by jruigrok
- Resolution set to fixed
- Status changed from assigned to closed
This is in place for 0.12 in trunk for a while. Double checked the default language working, it indeed defaults to the browser setup.
Committed a first version on the i18n sandbox in r6732.