Opened 16 years ago
Closed 16 years ago
#6765 closed enhancement (fixed)
Make language select a preference choice
| Reported by: | Jeroen Ruigrok van der Werven | Owned by: | Jeroen Ruigrok van der Werven |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | i18n | Version: | devel |
| Severity: | normal | Keywords: | i18n l10n |
| Cc: | Zoom.Quiet@…, jasminlapalme@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Right now we only use Accept-Language to negotiate the language, but we will need to add a choice in the preferences as well to allow people to set the language using a cookie.
Attachments (1)
Change History (12)
comment:1 by , 16 years ago
| Component: | general → i18n |
|---|
comment:2 by , 16 years ago
| Status: | new → assigned |
|---|
comment:3 by , 16 years ago
comment:4 by , 16 years ago
The only problem in the code is that it does not seem to switch languages. Cursory read-throughs by Alec (aat) and Christopher (cmlenz) indicate that the idea is good.
by , 16 years ago
| Attachment: | i18n_r6891_language_select.patch added |
|---|
comment:8 by , 16 years ago
| Cc: | added |
|---|
comment:9 by , 16 years ago
Committed in r6929. Thanks.
Seems it has one minor nit with regard to the default language. By the way, if I spelled your name wrong, let me know, I went with Jasmin Lapalme right now.
comment:10 by , 16 years ago
You spell it right.
The default language seems to be the language of the browser.
comment:11 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
This is in place for 0.12 in trunk for a while. Double checked the default language working, it indeed defaults to the browser setup.
Committed a first version on the i18n sandbox in r6732.