Edgewall Software
Modify

Ticket #6516 (reopened enhancement)

Opened 4 years ago

Last modified 5 months ago

[PATCH] Including content of ticket fields in outgoing notification email headers

Reported by: qwp0 Owned by: eblot
Priority: normal Milestone: next-major-0.1X
Component: notification Version:
Severity: normal Keywords: ghop consider review patch
Cc: doug.hellmann@…, androsis@…, thijstriemstra
Release Notes:
API Changes:

Description

I (as 'androsis') have claimed a ticket in GHOP ( http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=255 ) — "Update trac to include more ticket fields in outgoing email headers". There have been already posted some patchs, so it maybe useful for you to have a ticket here too.

I attach my most recent patch for this task (it can be found on the GHOP ticket of this issue too)…

P.S.: I have not found any existing ticket where I could post this, so if there is already a ticket about that I'm very sorry.

Attachments

trac-notification-headers_v3(tests).diff (2.3 KB) - added by qwp0 4 years ago.
trac-notification-x_trac_ticket_headers.diff (6.8 KB) - added by cboos 3 years ago.
copy of qwp0's patch linked in comment:9

Download all attachments as: .zip

Change History

Changed 4 years ago by qwp0

comment:1 Changed 4 years ago by anonymous

  • Cc doug.hellmann@… added

comment:2 Changed 4 years ago by anonymous

  • Summary changed from Including content of ticket fields in outgoing notification email headers to [PATCH] Including content of ticket fields in outgoing notification email headers

comment:3 Changed 4 years ago by sid

  • Type changed from defect to enhancement

comment:4 Changed 4 years ago by eblot

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #1359

comment:5 Changed 4 years ago by doug.hellmann

  • Resolution duplicate deleted
  • Status changed from closed to reopened

#1359 is not the same as this ticket.

In #1359, only changed fields are included in the header. In this ticket, all fields are always included in the headers.

The two patches could be merged or otherwise made compatible, but they don't provide the same functionality.

comment:6 Changed 4 years ago by cboos

  • Keywords consider added
  • Milestone set to 0.12

comment:7 Changed 4 years ago by androsis@…

  • Cc androsis@… added

comment:8 Changed 4 years ago by cboos

Closed #1359 as duplicate of this one.

We could eventually have something like a smtp_x_trac_ticket_headers option with the possible values of ALL, CHANGED or a list of fields.

comment:9 Changed 4 years ago by qwp0

Hi, I created a patch which works with the configuration option mentioned by Christian, created against the trunk repository, exactly r7639. I don't know if it's ideal because this ticket should be done for milestone:0.13.

Unfortunaly, because of the too extensive unit testing I can't upload it here, sorry — the file is available at http://tests.php5.sk/tmp/trac-notification-x_trac_ticket_headers.diff

I know it's none of my business now for the GHOP task (see the ticket description) is not actual but I hope the patch will be useful.

Changed 3 years ago by cboos

copy of qwp0's patch linked in comment:9

comment:10 Changed 18 months ago by thijstriemstra

  • Cc thijstriemstra added
  • Keywords review added

Patch needs a review.

comment:11 Changed 17 months ago by thijstriemstra

  • Keywords patch added

comment:12 Changed 5 months ago by jasa.david@…

Hi, is there any chance of getting this patch merged soon, to be able to make its way to 0.13?

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as reopened
as The resolution will be set. Next status will be 'closed'
to The owner will be changed from eblot. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.