Edgewall Software
Modify

Opened 16 years ago

Closed 13 years ago

#6512 closed enhancement (duplicate)

Add the user name of the author of a ticket change to the 'Sender' field

Reported by: niels.reedijk@… Owned by:
Priority: normal Milestone:
Component: notification Version: devel
Severity: normal Keywords: patch
Cc: Thijs Triemstra Branch:
Release Notes:
API Changes:
Internal Changes:

Description

We are trying to improve the usefulness of Trac's notification e-mails, by adding the user name to the 'Sender' field. This makes it easier to trac who made the changes in your e-mail app.

The patch works as follows: it adds a paramater to NotifyEmail's send method. The caller (in this case TicketNotify) can specify an author. Ticket notify looks up the author of a change, or the reporter in case of a new bug, and passes this on. The smtp_from_name parameter acts as an override, if it is set, the author parameter is ignored.

I doubt this patch conforms to your coding standards: it is meant as a quick hack to our local installation, nevertheless, it might be a solution for other users.

Attachments (1)

improved_notifications_6333.diff (2.4 KB ) - added by niels.reedijk@… 16 years ago.
Quick and dirty patch

Download all attachments as: .zip

Change History (8)

by niels.reedijk@…, 16 years ago

Quick and dirty patch

comment:1 by grant@…, 16 years ago

Hi - i'm really interested in getting this patch to work, but i can't seem to merge this into my notifications.py's, are you on 0.11 version??

comment:2 by anonymous, 16 years ago

Yes, it was made against revision 6361 (beta 1). I'm pretty sure it should apply cleanly. Perhaps you can apply it manually.

comment:3 by Emmanuel Blot, 16 years ago

See also #6789

comment:4 by Remy Blank, 15 years ago

Keywords: patch added
Milestone: 2.0
Owner: Emmanuel Blot removed

comment:5 by Christian Boos, 14 years ago

Milestone: 2.0unscheduled

Milestone 2.0 deleted

comment:6 by Thijs Triemstra, 13 years ago

Cc: Thijs Triemstra added

Also see #8360 that has a patch that grabs the name from the settings panel. #6789 is about using the email address of the ticket's owner in the reply-to header.

comment:7 by Remy Blank, 13 years ago

Milestone: unscheduled
Resolution: duplicate
Status: newclosed

#8360 has a patch implementing this functionality, so I'm closing this as a duplicate.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.