post-commit script example in trac-post-commit-hook is missing environment variable "TRAC_ENV"

[gsf@…]

The example post-commit script in the trac-post-commit-hook is missing the TRAC_ENV variable. See patch.

[eblot]

Not really: the comment section you're referring to explain how to get the environment variables from Subversion, i.e. how the Subversion server calls the hook script, passing the repository as the 1^st argument and the revision as the 2^nd argument.

TRAC_ENV needs to be given to the Python hook script.
However your patch refers to a shell script example that can be used to call the Python hook script in turn.

[eblot]

BTW, do not forget to report the version of Trac you're using when you submit a new ticket.

[gsf@…]

Please look at this patch again. The example shell script for Subversion needs TRAC_ENV, which is not assigned in the example in the comments. TRAC_ENV is used nowhere in the Python script.

I'm using Trac r6294.

[eblot]

Yes, you're right.

[cboos]

This is fixed in the new source:sandbox/multirepos/contrib/trac-svn-hook.