Edgewall Software

Ticket #6367 (new defect)

Opened 12 months ago

Last modified 12 months ago

[PATCH] Etag responses need Vary header

Reported by: Dave Gynn <dgynn@…> Owned by: cmlenz
Priority: normal Milestone: 0.11-retriage
Component: general Version: devel
Severity: normal Keywords: etag
Cc:

Description

The Request.check_modified() function which adds the Etag and checks If-None-Match should be adding a "Vary *" header along with the initial response and the 304 response.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.44

This creates a problem of the browser always caching attachments when mod_deflate is used. mod_deflate adds a "Vary Accept-Encoding" header which makes the browser believe that only Accept-Encoding is used to determine cacheability. "Vary *" is needed to let the browser know that other information is used to make caching decisions.

Also note that Request.send_file() function does not send a Cache-Control header. That should be OK if Vary * is sent.

Attachments

etag_vary.diff (477 bytes) - added by Dave Gynn <dgynn@…> 12 months ago.

Change History

Changed 12 months ago by Dave Gynn <dgynn@…>

Changed 12 months ago by cboos

  • keywords etag added
  • owner changed from jonas to cmlenz
  • milestone set to 0.11.1

cmlenz, can you validate the proposed approach?

Add/Change #6367 ([PATCH] Etag responses need Vary header)

Author



Change Properties
<Author field>
Action
as new
as The resolution will be set. Next status will be 'closed'
to The owner will change from cmlenz. Next status will be 'new'
The owner will change from cmlenz to anonymous. Next status will be 'assigned'
 
Note: See TracTickets for help on using tickets.