Modify ↓
Ticket #597 (closed defect: fixed)
Opened 8 years ago
Last modified 6 years ago
Ampersand (&) in Project title breaks timeline RSS feed
| Reported by: | Ian Leader <ian_dot_leader_at_line_dot_co_dot_uk> | Owned by: | daniel |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.8 |
| Component: | timeline | Version: | 0.7.1 |
| Severity: | normal | Keywords: | RSS, escapes, reports |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
If there is an ampersand in the Trac project title, it is not escaped in the RSS timeline feed, and consequently the feed is not well-formed XML.
This may well be the case in other RSS feeds, but I changed the title of our project before I thought to check.
Attachments
Change History
comment:1 Changed 8 years ago by daniel
- Owner changed from jonas to daniel
- Status changed from new to assigned
Changed 8 years ago by anonymous
- Attachment rss_title_esc_fix_trunc_803.diff added
comment:2 Changed 8 years ago by Ian Leader <ian_dot_leader_at_line_dot_co_dot_uk>
- Keywords escapes, reports added; escapes removed
comment:3 Changed 8 years ago by daniel
- Milestone set to 0.8
comment:4 Changed 8 years ago by daniel
- Resolution set to fixed
- Status changed from assigned to closed
Applied in [825]. Thanks for the patch, Ian! Escaping entities might be a bigger issue than just RSS, and might become apparent later.
Note: See
TracTickets for help on using
tickets.
Have attached diff to source:/trunk/#803 to fix this ticket, and to fix the same problem in the report RSS feed.
Took the approach of adding project.name.rss value, and updating the templates, as this seemed to be the aproach taken to item-based RSS kludges in [803].
the hdf.setValue is in core.py - this seemed the most sensible place, as this problem will occur in pretty much any RSS feed, but if there is a better place, please let me know.