Edgewall Software
Modify

Ticket #5576 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Inappropiate/Missing svn:eol-style for 0.10.x files: ticket_notify_email.cs and ticket_rss.cs

Reported by: Johans Marvin Taboada Villca <jmt4b04d4v@…> Owned by: jonas
Priority: low Milestone: 0.11
Component: general Version: 0.10-stable
Severity: minor Keywords: svn:eol-style
Cc: jmt4b04d4v@…

Description

Clearsilver template files in 0.10-stable branch have Subversion svn:eol-style property set to native except for the following files:

Recently I created a patch to provide spanish translation of  templates for 0.10.x, but had problems setting svn:eol-style property to native in the generated patch file. Subversion complaint that content had mixed EOL.

Is there a reason to maintain this? could this be normalized, Thanks

Attachments

Change History

comment:2 Changed 3 years ago by cboos

  • Milestone changed from 0.10.5 to 0.11

We should standardize all the relevant files to "native" for 0.11.

Caveats:

  • the .bat/.cmd files needs to be always "CRLF"
  • the svnrepos.dump needs to be always "LF"

(well, I just checked - they already are)

comment:3 Changed 3 years ago by cboos

  • Status changed from new to closed
  • Resolution set to fixed

All text files were normalized to "native" in r6324 (explicit exceptions mentioned in the comment above)

comment:4 Changed 3 years ago by jmt4b04d4v

Replying to cboos:

We should standardize all the relevant files to "native" for 0.11.

Could this be ported to 0.10-stable branch?. That's why I set this initially for 0.10.5 milestone.

By the way, the following link branches/0.10-stable/templates/ticket_notify_email.cs@3468 (originally reported in ticket:5576:description) is broken. I've made a mistake in URL/revision combination (that revision was committed on trunk before branching).

comment:5 Changed 3 years ago by cboos

No, I don't think we'll make any other non-critical change on 0.10.x at this point, as we're about to make the 0.11 release.

The 0.10.x tickets will progressively be moved to 0.11.x or later, as appropriate, or closed as wontfix if they are Clearsilver specific.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from jonas. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.