Ticket #539 (closed defect: fixed)
Opened 8 years ago
Last modified 8 years ago
timeline RSS <image> <link> url is just the http://hostname/, not link to timeline
| Reported by: | radix | Owned by: | daniel |
|---|---|---|---|
| Priority: | low | Milestone: | 0.8 |
| Component: | timeline | Version: | 0.7.1 |
| Severity: | minor | Keywords: | timeline rss image link url |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
While the <channel> <link> is correct, the <image> <link> just points to e.g. http://twistedmatrix.com/ instead of http://twistedmatrix.com/trac/imagination/trac/timeline. It's a very simple fix to timeline_rss.cs:
--- /home/trac/TRAC/trac-0.7.1/templates/timeline_rss.cs 2004-05-20 21:59:41.000000000 +0000
+++ /home/trac/usr/share/trac/templates/timeline_rss.cs 2004-06-11 17:04:57.000000000 +0000
@@ -25,7 +25,7 @@
<image>
<title><?cs var:$project.name?></title>
<url><?cs if !$header_logo.src_abs ?><?cs var:$base_url ?><?cs /if ?><?cs var $header_logo.src ?></url>
- <link><?cs var:$base_url ?></link>
+ <link><?cs var:$base_url ?><?cs var:$trac.href.timeline ?></link>
</image>
<?cs each:item = $timeline.items ?>
<?cs if:item.type == #1 ?><!-- Changeset -->
Attachments
Change History
comment:1 Changed 8 years ago by radix
Changed 8 years ago by radix
- Attachment timeline.patch added
timeline_rss.cs patch to fix <image> <link>
comment:2 Changed 8 years ago by daniel
- Milestone set to 0.8
- Owner changed from jonas to daniel
- Priority changed from normal to low
- Severity changed from normal to minor
- Status changed from new to assigned
comment:3 Changed 8 years ago by daniel
- Resolution set to fixed
- Status changed from assigned to closed
Applied and fixed in [769]. Many thanks for the patch!
Sorry, I assumed that the comments were <pre>d. I'll attach the patch.