Edgewall Software

Ticket #5383 (closed defect: fixed)

Opened 16 months ago

Last modified 15 months ago

Akismet throws when marking something via monitoring

Reported by: Nils Maier <MaierMan@…> Owned by: cboos
Priority: high Milestone: not applicable
Component: plugin/spamfilter Version: devel
Severity: critical Keywords:
Cc:

Description

As author is None for anonymous users author.encode('utf-8') fails.

Patch + Traceback attached.

Attachments

trac-spamfilter-akismet-author.diff (0.5 kB) - added by Nils Maier <MaierMan@…> 16 months ago.
trac-spamfilter-akismet-author-tb.log (1.5 kB) - added by Nils Maier <MaierMan@…> 16 months ago.

Change History

Changed 16 months ago by Nils Maier <MaierMan@…>

Changed 16 months ago by Nils Maier <MaierMan@…>

Changed 16 months ago by cboos

  • owner changed from mgood to cboos
  • status changed from new to assigned
  • milestone set to not applicable

The Akismet filter was the only filter making use of the author parameter, but the problem was more general, so I've fixed it in a different way than in the proposed patch.

Changed 16 months ago by cboos

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in r5517.

The API doc for FilterSystem.test(req, author, changes) specifies that:

author: the name of the logged in user, or 'anonymous' if the user is not logged in

Therefore the filters should be able to expect this as well. We simply ensure in FilterSystem.test that this will always be the case, and have an additional check in FilterSystem.train when fetching log entries saved before the fix.

Changed 15 months ago by cboos

Just got hit by this on t.e.o, can someone upgrade the spamfilter to the latest? Thanks.

Add/Change #5383 (Akismet throws when marking something via monitoring)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.