Edgewall Software
Modify ↓

Ticket #5277 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

Expand dir feature: table width/height issue

Reported by: eblot Owned by: cboos
Priority: normal Milestone: 0.11
Component: version control/browser Version: devel
Severity: minor Keywords: css
Cc:
Release Notes:
API Changes:

Description

See attached snapshots:

When a folder is expanded or folded, the height of the related row is modified, which looks dirty.

Snapshots taken from WebKit, but I've been able to reproduce the same issue with Firefox 2.x. It really depends on the actual width of the browser window; anyway it seems to be a matter of telling the browser where to break a line when a full row does not fit in the browser window.

Attachments

expand_dir_expand.png​ (10.9 KB) - added by eblot 5 years ago.
simple height
expand_dir_fold.png​ (11.2 KB) - added by eblot 5 years ago.
double height

Download all attachments as: .zip

Change History

Changed 5 years ago by eblot

simple height

Changed 5 years ago by eblot

double height

comment:1 Changed 5 years ago by eblot

  • Component changed from general to browser
  • Owner changed from jonas to cboos

comment:2 Changed 5 years ago by cboos

  • Milestone set to 0.11
  • Status changed from new to assigned

Should be fixed in r5358, can you confirm?

comment:3 Changed 5 years ago by cboos

Well, try r5362...

comment:4 Changed 5 years ago by eblot

  • Resolution set to fixed
  • Status changed from assigned to closed

Yeah, you've fixed it. Thanks.

comment:5 Changed 4 years ago by cboos

  • Milestone changed from 0.11 to 0.11.1
  • Priority changed from low to normal
  • Resolution fixed deleted
  • Status changed from closed to reopened

The problem reappeared, need to have another look.

comment:6 Changed 4 years ago by cboos

  • Keywords css added

Things get slightly better with this change:

  • trac/htdocs/css/browser.css 

    diff -r ed4269932176 trac/htdocs/css/browser.css
    a b div.message { 
    7373 padding-left: 20px; 
    7474} 
    7575#dirlist td.name a.parent { background-image: url(../parent.png) } 
     76#dirlist td.name div { white-space: pre } 
    7677#dirlist tr span.expander { 
    7778  background-image: url(../expander_normal.png); 
    7879  cursor: pointer; 

Works fine in IExplorer and Opera, but in Firefox it can lead to a small overlap on the size column for the cell which used to be wrapped (the "armimglib" folder in the attachment:expand_dir_fold.png​ sample).

If someone has a better fix, I'm all ears.

comment:7 Changed 4 years ago by cboos

  • Milestone changed from 0.11.1 to 0.11
  • Resolution set to fixed
  • Severity changed from trivial to minor
  • Status changed from reopened to closed

Above fix committed as [6274].

View ↑

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cboos. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.