Edgewall Software

Ticket #5277 (closed defect: fixed)

Opened 19 months ago

Last modified 12 months ago

Expand dir feature: table width/height issue

Reported by: eblot Owned by: cboos
Priority: normal Milestone: 0.11
Component: version control/browser Version: devel
Severity: minor Keywords: css
Cc:

Description

See attached snapshots:

When a folder is expanded or folded, the height of the related row is modified, which looks dirty.

Snapshots taken from WebKit, but I've been able to reproduce the same issue with Firefox 2.x. It really depends on the actual width of the browser window; anyway it seems to be a matter of telling the browser where to break a line when a full row does not fit in the browser window.

Attachments

expand_dir_expand.png (10.9 KB) - added by eblot 19 months ago.
simple height
expand_dir_fold.png (11.2 KB) - added by eblot 19 months ago.
double height

Change History

Changed 19 months ago by eblot

simple height

Changed 19 months ago by eblot

double height

Changed 19 months ago by eblot

  • owner changed from jonas to cboos
  • component changed from general to browser

Changed 19 months ago by cboos

  • status changed from new to assigned
  • milestone set to 0.11

Should be fixed in r5358, can you confirm?

Changed 19 months ago by cboos

Well, try r5362...

Changed 19 months ago by eblot

  • status changed from assigned to closed
  • resolution set to fixed

Yeah, you've fixed it. Thanks.

Changed 12 months ago by cboos

  • priority changed from low to normal
  • status changed from closed to reopened
  • resolution fixed deleted
  • milestone changed from 0.11 to 0.11.1

The problem reappeared, need to have another look.

Changed 12 months ago by cboos

  • keywords css added

Things get slightly better with this change:

  • trac/htdocs/css/browser.css

    diff -r ed4269932176 trac/htdocs/css/browser.css
    a b  
    7373 padding-left: 20px; 
    7474} 
    7575#dirlist td.name a.parent { background-image: url(../parent.png) } 
     76#dirlist td.name div { white-space: pre } 
    7677#dirlist tr span.expander { 
    7778  background-image: url(../expander_normal.png); 
    7879  cursor: pointer; 

Works fine in IExplorer and Opera, but in Firefox it can lead to a small overlap on the size column for the cell which used to be wrapped (the "armimglib" folder in the attachment:expand_dir_fold.png sample).

If someone has a better fix, I'm all ears.

Changed 12 months ago by cboos

  • status changed from reopened to closed
  • resolution set to fixed
  • severity changed from trivial to minor
  • milestone changed from 0.11.1 to 0.11

Above fix committed as [6274].

Add/Change #5277 (Expand dir feature: table width/height issue)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cboos. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.