Edgewall Software
Modify

Ticket #5126 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

trac should have an option to obscure all email addresses

Reported by: anonymous Owned by: cboos
Priority: normal Milestone: 0.11
Component: ticket system Version: devel
Severity: minor Keywords: email obfuscation CC field
Cc:
Release Notes:
API Changes:

Description

Currently if you add an email address to a ticket's cc, it will be publicly displayed on the webpage. It would be nice if there were a way to obscure this to prevent the addresses from being harvested by spammers. I've attached a prototype to demonstrate the functionality I'd like, but it's not well integrated with the rest of the system.

Thanks!

Attachments

email.patch (1.3 KB) - added by anonymous 5 years ago.
1459.diff (1.3 KB) - added by cboos 5 years ago.
Updated the CC: rendering patch that eblot posted on #1459, which adds e-mail obfuscation (#153 style)
5126.diff (2.2 KB) - added by eblot 5 years ago.
Combination of both patches

Download all attachments as: .zip

Change History

Changed 5 years ago by anonymous

comment:1 Changed 5 years ago by cboos

  • Milestone set to 0.11
  • Owner changed from jonas to cboos
  • Severity changed from normal to minor

Thanks, that was one of the missing pieces for #153.

I still hope that we would provide flexible renderers for ticket fields, but in the meantime, this should be a start.

(to be done after the WorkFlow merge)

Changed 5 years ago by cboos

Updated the CC: rendering patch that eblot posted on #1459, which adds e-mail obfuscation (#153 style)

comment:2 Changed 5 years ago by cboos

  • Keywords email obfuscation CC field added
  • Owner changed from cboos to eblot
  • Version set to devel

Changed 5 years ago by eblot

Combination of both patches

comment:3 Changed 5 years ago by eblot

I've combined both patches in one file, but I should say that I'm a bit skeptical about the cc address obfuscation:

We can hide the domain in the CC field of the ticket property box, but we cannot do the same in the CC: text field: email addresses appear with the FQDN, and we cannot mask the domain here.

comment:4 Changed 5 years ago by cboos

Wait, why don't you use format_author like shown in attachment:1459.diff? (that function takes into account the EMAIL_VIEW permission).

Then, for the CC: text field, we could go one little step further and only show it in full for TICKET_ADMINs and have a checkbox: [ ] Add me to CC or [ ] Remove me from CC depending if the current e-mail address if found or not in the field. No datamodel change for that, so this is not really the plan for #1459 but more a workaround for being able to correctly hide the e-mails.

comment:5 Changed 5 years ago by eblot

I guess we both are not refering to the same patch: none of the patches described here contain format_author.

Maybe attachment:ticket:153:privacy-r4476.diff is the right candidate?

comment:6 Changed 5 years ago by cboos

That patch on #153 (or similar) is applied since a long time; no I really meant attachment:1459.diff, my slightly modified version of your patch attached here.

comment:7 Changed 5 years ago by cboos

  • Owner changed from eblot to cboos

I'm refactoring a bit the ticket system so that the fields would be rendered in the template in a way similar to browser properties. So this feature will be better done inside the web_ui not in the template.

comment:8 Changed 5 years ago by cboos

  • Status changed from new to assigned

Done in r5485 (FieldRefactoring branch)

comment:9 Changed 5 years ago by ThurnerRupert

see also #5378 for ajax support.

comment:10 Changed 5 years ago by cboos

  • Milestone changed from 0.11.1 to 0.11

Nearly there in trunk with r5812 and r5813.

Actually, r5812 was about the display of CC: changes in the HTML Change History and in the RSS view of the ticket, not yet when showing changes between arbitrary versions of the Ticket (i.e. the ticket diff view).

comment:11 Changed 5 years ago by cboos

  • Resolution set to fixed
  • Status changed from assigned to closed

Finalized in r5814.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cboos. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.