diffing two large trees results in a massive list with a lot of empty links

[theultramage@…]

If I run the diff in the following link, instead of directly showing all the diffs, it displays a list of links to the diffs of individual files.

That wouldn't be too bad (it's probably intended to reduce browser load but I'd like to be able to customize the behavior somehow - help!), but in the above case, many of the links lead to empty diffs, which is obviously wrong. Please fix it so it only links to non-empty diffs.

[eblot]

Replying to theultramage@gmail.com:

That wouldn't be too bad (it's probably intended to reduce browser load but I'd like to be able to customize the behavior somehow - help!),

About this peculiar point: did you set up the Trac parameters as described in TracIni#changeset-section (max_diff_*)?

[theultramage@…]

Yes I noticed that one shortly after, and it works for that particular subdirectory. (although when I ran it on the root dir it rattled for a while and then gave up with no error messages or anything :)

[cboos]

Yes, this is a real issue in SubversionRepository.get_changes() that I still need to investigate.

[theultramage@…]

This was fixed sometime in january, probably by r4548 (but not sure).

[cboos]

Replying to theultramage@gmail.com:

This was fixed sometime in january, probably by r4548 (but not sure).

Ah, then we were not speaking of the same thing. I noticed that this happened when comparing different branches, and that spurious diffs were appearing for binaries, like in, e.g.

diff:trunk/htdocs@4700//sandbox/security/htdocs@4700

(those are actually the same pictures)

[theultramage@…]

Hm, in my case it was probably caused by the tree-diffing engine not skipping empty diffs (see example, the first file). This doesn't happen anymore on trunk. Maybe a case needs to be added for binary files?

[cboos]

Ok thanks for the example, it helps to understand the issue.

[anonymous]

Update; the situation still happens, but it seems that only for larger diffs. I needed to do a diff of two entire branches (with almost the same content) today, and it still gave me a huge list with "(No files)" inside. I hope it is reproducible.

[cboos]

The bug will probably stay until after the 0.11 release, but could probably be then backported to 0.11-stable.