Ticket #4383 (closed enhancement: fixed)
Opened 5 years ago
Last modified 5 years ago
CORE - Loader should load single-file plugins after egg plugins
| Reported by: | ilias@… | Owned by: | cmlenz |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11 |
| Component: | general | Version: | devel |
| Severity: | normal | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
The trac loader should load single-file plugins after the egg-plugins.
Single-File plugins rely more on egg-plugins than egg-plugins on single-file-plugins.
see example thread .
related ticket: #4317
Attachments
Change History
comment:1 follow-up: ↓ 2 Changed 5 years ago by Noah Kantrowitz <coderanger@…>
comment:2 in reply to: ↑ 1 Changed 5 years ago by ilias@…
Replying to Noah Kantrowitz <coderanger@yahoo.com>:
If any dependency is required, do not use a single-file plugin. The requirement should be documented in a way Trac (and setuptools) can see, which requires an egg. Using setuptools is not hard enough that it warrants additional hackery around the single-file system IMO. Propose a wontfix for this.
Single-file "system"? - what system? there's just a piece of draft-code.
Keep things complicated, thus users struggle even more and need the expertise of the team members.
"hackery"? - no hackery needed:
simply move this code block (single-file loader):
source:trunk/trac/loader.py@3557#L43
after this one (egg loader):
source:trunk/trac/loader.py@3557#L62
To have a more logical plugin-type-load-order (single-file after egg)
comment:3 Changed 5 years ago by cmlenz
- Milestone set to 0.11
- Owner changed from jonas to cmlenz
- Status changed from new to assigned
It certainly makes sense to load single-file plugins after eggs.
comment:4 Changed 5 years ago by mgood
- Resolution set to fixed
- Status changed from assigned to closed
This was fixed in r4633.



If any dependency is required, do not use a single-file plugin. The requirement should be documented in a way Trac (and setuptools) can see, which requires an egg. Using setuptools is not hard enough that it warrants additional hackery around the single-file system IMO. Propose a wontfix for this.