Edgewall Software
Modify

Ticket #4326 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

diff.js chops off version number

Reported by: Tim Hatch <trac@…> Owned by: cboos
Priority: normal Milestone: 0.11
Component: general Version: devel
Severity: trivial Keywords:
Cc:
Release Notes:
API Changes:

Description

source:trunk/htdocs/js/diff.js@4282#L10 does a substr(5) call on the titles, and I don't know why. In trunk, these titles look like "Revision 1", so chopping off the first few characters results in something like this being produced:

--- ion 3
+++ ion 18

In trying to come up with patches to fix #4322, it gets more complicated because the title when used in a ticket could be "Initial Version".

cmlenz, is there a reason for the substr call, rather than taking the whole title?

Attachments

Change History

comment:1 Changed 5 years ago by cboos

  • Milestone set to 0.11
  • Owner changed from cmlenz to cboos
  • Severity changed from normal to trivial
  • Status changed from new to assigned

is there a reason for the substr call, rather than taking the whole title?

I assume there was one, but as +++ Revision looks better than +++ ion, I'm going to fix this little glitch ;)

comment:2 Changed 5 years ago by cboos

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r4674.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cboos. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.