Modify ↓
Ticket #4312 (closed defect: fixed)
Opened 5 years ago
Last modified 5 years ago
Attachment to ticket in timeline lacks title for ticket reference
| Reported by: | Tim Hatch <trac@…> | Owned by: | cboos |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11 |
| Component: | timeline | Version: | devel |
| Severity: | trivial | Keywords: | attachment |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
For example, I see on the timeline right now <em>timeline_spelling.patch</em> attached to ticket <em>#4310</em>. I'm used to having a tooltip over things on the timeline that have a ticket reference, like for ticket changes, Ticket <em title="Ticket Title">#4310</em>....
This patch does it just for tickets by modifying the display callback. I'm not sure about the speed penalty.
-
trac/ticket/web_ui.py
545 545 # Attachments 546 546 if 'ticket_details' in filters: 547 547 def display(id): 548 return html('ticket ', html.em('#', id ))548 return html('ticket ', html.em('#', id, title=Ticket(self.env, id)['summary'])) 549 549 att = AttachmentModule(self.env) 550 550 for event in att.get_timeline_events(req, db, 'ticket', 551 551 start, stop, display):
Observed on t.e.o and reproduced on trunk.
Attachments
Change History
comment:1 Changed 5 years ago by cboos
- Keywords attachment added
- Milestone set to 0.11
- Owner changed from jonas to cboos
- Severity changed from normal to trivial
comment:2 Changed 5 years ago by cboos
- Resolution set to fixed
- Status changed from new to closed
Added in r4391.
Note: See
TracTickets for help on using
tickets.



Well, this introduces no more overhead than if that would have been a regular comment for that ticket, so I guess it's OK.