Ticket #4191 (closed enhancement: duplicate)
Opened 5 years ago
Last modified 5 years ago
CORE - Allow Removal of navigation items from within trac.ini
| Reported by: | ilias@… | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | general | Version: | devel |
| Severity: | trivial | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
The goal is to allow easy customization, without alteration of code and templates.
Thus the scope of this ticket is very small.
Suggested implementation:
mainnav = wiki, -timeline, ...
The timeline item would be removed in this case (prefix with "-"). Another option would be the "!", but this could be missleading with the functionality within the wiki
Attachments
Change History
comment:1 Changed 5 years ago by simon-code@…
comment:2 Changed 5 years ago by Noah Kantrowitz (coderanger) <coderanger@…>
This is also a pretty trivial plugin. Perhaps a Request-a-Hack is in order?
comment:3 follow-up: ↓ 4 Changed 5 years ago by mgood
- Keywords needinfo added
- Priority changed from normal to low
- Severity changed from normal to trivial
I think disabling modules is generally the preferable solution. Removing permissions will still leave those modules visible to users with TRAC_ADMIN permission.
Do you have a specific reason to leave a module enabled, but inaccessible through the UI? I think this is a wontfix or worksforme since disabling the module already does what you've asked for, but I'll leave it open temporarilly for feedback.
comment:4 in reply to: ↑ 3 Changed 5 years ago by ilias@…
Replying to mgood:
I think disabling modules is generally the preferable solution. Removing permissions will still leave those modules visible to users with TRAC_ADMIN permission.
Do you have a specific reason to leave a module enabled, but inaccessible through the UI?
The reason is to provide flexibility in the interface-customization.
I could e.g. remove the "help/guide", "about" menus and enable them in another location of the UI.
The goal is to enable users to customize trac without interventions which make seperate maintenance neccessary (e.g. custom templates). This way those users can keep their "custom-trac" closer to the original one, enabling back-contribution of their code to the trac project.
I think this is a wontfix or worksforme since disabling the module already does what you've asked for, but I'll leave it open temporarilly for feedback.
I've seen several user requests asking for this functionality.
And I've seen several sites {http://code.djangoproject.com/ see example] which remove such navigation links, without disabling the content.
Trac should simplify the creation of Custom Versions
comment:5 follow-up: ↓ 6 Changed 5 years ago by Noah Kantrowitz (coderanger) <coderanger@…>
This has been implemented in a plugin. I would propose a wontfix for this ticket.
comment:6 in reply to: ↑ 5 ; follow-up: ↓ 7 Changed 5 years ago by ilias@…
Replying to Noah Kantrowitz (coderanger) <coderanger@yahoo.com>:
This has been implemented in a plugin. I would propose a wontfix for this ticket.
What you (or any other person, even committers of trac) implements as a plugin on "trac-hacks" has no relevance to the state of this ticket, which affects the core of trac.
(sidenote: Similar tickets could e.g. ask to integrate existing plugin-functionality where it belongs to: to the core)
The Plugin mechanism is an powerfull mechanism, which (when not used correctly), can lead to a very bad design and usability (as it's currently the status with trac, which needs a hand-full of un-coordinated plugins to become operative/usable in typical environments).
Of course I am not going to install and maintain for every tiny bit of functionality a plugin.
As to your plugin description: you should at least point to this ticket (from which your implementation idea originates).
And finally: having 2 options "-" and "!" should be avoided ("!" for the reason stated, as it's missleading/conflicting with the wiki functionality).
comment:7 in reply to: ↑ 6 Changed 5 years ago by ilias@…
Replying to ilias@lazaridis.com:
As to your plugin description: you
correction of link: http://trac-hacks.org/wiki/NavHiderPlugin
Changed 5 years ago by ilias@…
- Attachment EnableNavItemRemoval.diff added
comment:8 Changed 5 years ago by ilias@…
The provided patch implements this functionality within the core, providing users with a simple intuitive way to customize the trac UI. The implementation does not break existent behaviour.
Changed 5 years ago by ilias@…
- Attachment EnableNavItemRemoval2.diff added
comment:9 Changed 5 years ago by ilias@…
provided patch did not work on multiple removals.
New patch uses a duplicate of the list:
comment:10 Changed 5 years ago by ilias@…
- Keywords needinfo removed
- Owner jonas deleted
willfix or wontfix?
comment:11 Changed 5 years ago by cboos
- Resolution set to duplicate
- Status changed from new to closed
Superseded by #2060.



There are already ways of doing this:
If the intention is not to use a feature as the Timeline, it is much better to disable it than merely to hide the navigation.