Modify ↓
Ticket #4185 (closed defect: fixed)
Opened 5 years ago
Last modified 5 years ago
timeline.rss not updated with r4214 and r4224
| Reported by: | Tim Hatch <trac@…> | Owned by: | jonas |
|---|---|---|---|
| Priority: | low | Milestone: | 0.11 |
| Component: | timeline | Version: | devel |
| Severity: | minor | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
templates/timeline.rss needs to be updated for the changes made to 4214 and 4224. I'm attaching my try, which appears to work.
Attachments
Change History
Changed 5 years ago by Tim Hatch <trac@…>
- Attachment timeline-rss-4214-4224.diff added
comment:1 Changed 5 years ago by cboos
comment:2 Changed 5 years ago by cmlenz
- Milestone set to 0.11
I actually applied the patch in [4334], but agree it would be better to use wiki_to_html to get the full text.
comment:3 Changed 5 years ago by cmlenz
- Resolution set to fixed
- Status changed from new to closed
Updated in [4336].
comment:4 Changed 5 years ago by mgood
- Resolution fixed deleted
- Status changed from closed to reopened
Since this has eliminated the use of the use_oneliner and shorten_oneliner options they should be removed from the code as well.
comment:5 Changed 5 years ago by cboos
- Resolution set to fixed
- Status changed from reopened to closed
No, those remains useful for the HTML view. There, the ITimelineEventProvider are in control of what should be shown, and those fields are set according to the various configuration options we already have.
Note: See
TracTickets for help on using
tickets.
Well, the wiki_to_html was done on purpose for the RSS output. The reasoning was that the RSS Reader would eventually truncate the message when appropriate, but otherwise it would have the full information at its disposal.
So do you really think it would be better to make it a one liner?