Ticket #4143 (closed defect: worksforme)
Opened 5 years ago
Last modified 5 years ago
JavaScript error on wiki pages
| Reported by: | Noah Kantrowitz (coderanger) <coderanger@…> | Owned by: | mgood |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | wiki system | Version: | 0.10 |
| Severity: | trivial | Keywords: | |
| Cc: | alarionov3@… | ||
| Release Notes: | |||
| API Changes: | |||
Description
There is a JavaScript error in the addLinks function, title has no properties. This is because in the wiki template, addHeadingLinks is only called with one argument.
Attachments
Change History
comment:1 Changed 5 years ago by mgood
- Milestone changed from 0.11 to 0.10.2
- Owner changed from jonas to mgood
comment:2 Changed 5 years ago by Larionov Andrey <alarionov3@…>
- Cc alarionov3@… added
Is this bug a so hard fixing. Maybe it can be fast fixed and ported in 0.10 branch or maybe you can provide temporary patch.
My users are tired of IE error message.
comment:3 Changed 5 years ago by cboos
- Milestone 0.10.3 deleted
- Resolution set to worksforme
- Status changed from new to closed
This is because in the wiki template, addHeadingLinks is only called with one argument.
Really? That was changed a long time ago: [3564/trunk/templates/wiki.cs].
You're probably using customized templates, check what your TracIni setting is:
[trac] templates_dir = /path/to/your/templates
and compare those templates with the "official" ones.
Anyway, if someone has the error in his modified template, the changeset linked above should be enough for showing how to fix this problem.
comment:4 Changed 5 years ago by Larionov Andrey <alarionov3@…>
Sounds strange, but my template is up to date. I chek trac.ini. Path to templates is correct. But in page source (in browser) there is
addHeadingLinks(document.getElementById("searchable"));
instead of addHeadingLinks(document.getElementById("searchable"), "Link to this section");
comment:5 Changed 5 years ago by cboos
Well, try to modify the template you think is getting used (add some random <h1>HELLO!</h1>) and see if that shows up...
comment:6 Changed 5 years ago by Larionov Andrey <alarionov3@…>
There is no results on page. I'm using FastCGI frontend. Mybe ClearSilver is caching templates?
comment:7 Changed 5 years ago by cboos
I've never used FastCGI myself, but I guess that you need a server restart.
comment:8 Changed 5 years ago by Larionov Andrey <alarionov3@…>
I'm restart server twice
#3729 has been marked as a duplicate.