Edgewall Software

Ticket #4143 (closed defect: worksforme)

Opened 2 years ago

Last modified 2 years ago

JavaScript error on wiki pages

Reported by: Noah Kantrowitz (coderanger) <coderanger@…> Owned by: mgood
Priority: low Milestone:
Component: wiki system Version: 0.10
Severity: trivial Keywords:
Cc: alarionov3@…

Description

There is a JavaScript error in the addLinks function, title has no properties. This is because in the wiki template, addHeadingLinks is only called with one argument.

Attachments

Change History

Changed 2 years ago by mgood

  • owner changed from jonas to mgood
  • milestone changed from 0.11 to 0.10.2

#3729 has been marked as a duplicate.

Changed 2 years ago by Larionov Andrey <alarionov3@…>

  • cc alarionov3@… added

Is this bug a so hard fixing. Maybe it can be fast fixed and ported in 0.10 branch or maybe you can provide temporary patch.

My users are tired of IE error message.

Changed 2 years ago by cboos

  • status changed from new to closed
  • resolution set to worksforme
  • milestone 0.10.3 deleted

This is because in the wiki template, addHeadingLinks is only called with one argument.

Really? That was changed a long time ago: [3564/trunk/templates/wiki.cs]. You're probably using customized templates, check what your TracIni setting is:

[trac]
templates_dir = /path/to/your/templates

and compare those templates with the "official" ones.

Anyway, if someone has the error in his modified template, the changeset linked above should be enough for showing how to fix this problem.

Changed 2 years ago by Larionov Andrey <alarionov3@…>

Sounds strange, but my template is up to date. I chek trac.ini. Path to templates is correct. But in page source (in browser) there is
addHeadingLinks(document.getElementById("searchable"));
instead of addHeadingLinks(document.getElementById("searchable"), "Link to this section");

Changed 2 years ago by cboos

Well, try to modify the template you think is getting used (add some random <h1>HELLO!</h1>) and see if that shows up...

Changed 2 years ago by Larionov Andrey <alarionov3@…>

There is no results on page. I'm using FastCGI frontend. Mybe ClearSilver is caching templates?

Changed 2 years ago by cboos

I've never used FastCGI myself, but I guess that you need a server restart.

Changed 2 years ago by Larionov Andrey <alarionov3@…>

I'm restart server twice

Add/Change #4143 (JavaScript error on wiki pages)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from mgood. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.