Assertion failed: is_canonical(base, blen) while view changeset in DIFF/ZIP format

[anonymous]

1. set repository_dir to folder inside a repository, for example, d:\svn\repos\folder

2. view changeset and choose one of the format below "Download in other formats"

3. apache server dead due to SVN crash

Assertion failed: is_canonical(base, blen), file C:\Projects\subversion-1.4.0\subversion\libsvn_subr\path.c, line 114

There is no such problem is repository_dir is root of repository. All SVN verison and same problem there

[cboos]

Unbelievable but true ;)

[cboos]

Looks like repos.svn_repos_dir_delta dislikes leading slashes. Well, if only svn could say that in a nicer way...

Some background info:

•  http://lists.alioth.debian.org/pipermail/pkg-subversion-maintainers/2006-March/000546.html
•  http://svn.collab.net/svn-doxygen/svn__path_8h.html

The follow change fixes the problem:

trac/versioncontrol/svn_fs.py

@@ -489 +489 @@
             text_deltas = 0 # as this is anyway re-done in Diff.py...
             entry_props = 0 # "... typically used only for working copy updates"
             repos.svn_repos_dir_delta(old_root,
-                                      _to_svn(self.scope, old_path), '',
+                                      _to_svn(self.scope + old_path), '',
                                       new_root,
                                       _to_svn(self.scope + new_path),
                                       e_ptr, e_baton, authz_cb,

but I need to give it more testing before I commit it.

[cboos]

Patch applied in r4013 (trunk) and r4017 (0.10-stable).

[Markus Tacker <m@…>]

With r4809 (0.10-stable) I get this error.

# trac-admin /var/trac/phpbb-rss resync
Resyncing repository history...
python: subversion/libsvn_subr/path.c:114: svn_path_join: Assertion `is_canonical(base, blen)' failed.

Is it related?

[cboos]

Replying to Markus Tacker <m@tacker.org>:

> # trac-admin /var/trac/phpbb-rss resync

Can you redo it with DEBUG level logging, please?

[Markus Tacker <m@…>]

Replying to cboos:

Can you redo it with DEBUG level logging, please?

That's all I get:

2007-03-01 10:53:10,652 Trac[loader] DEBUG: Loading egg plugin webadmin.logging from /usr/lib/python2.4/site-packages/TracWebAdmin-0.1.2dev_r4429-py2.4.egg
2007-03-01 10:53:10,654 Trac[loader] DEBUG: Loading egg plugin webadmin.ticket from /usr/lib/python2.4/site-packages/TracWebAdmin-0.1.2dev_r4429-py2.4.egg
2007-03-01 10:53:10,656 Trac[loader] DEBUG: Loading egg plugin webadmin.basics from /usr/lib/python2.4/site-packages/TracWebAdmin-0.1.2dev_r4429-py2.4.egg
2007-03-01 10:53:10,658 Trac[loader] DEBUG: Loading egg plugin webadmin.perm from /usr/lib/python2.4/site-packages/TracWebAdmin-0.1.2dev_r4429-py2.4.egg
2007-03-01 10:53:10,659 Trac[loader] DEBUG: Loading egg plugin webadmin.web_ui from /usr/lib/python2.4/site-packages/TracWebAdmin-0.1.2dev_r4429-py2.4.egg
2007-03-01 10:53:10,660 Trac[loader] DEBUG: Loading egg plugin webadmin.plugin from /usr/lib/python2.4/site-packages/TracWebAdmin-0.1.2dev_r4429-py2.4.egg
2007-03-01 10:53:10,668 Trac[loader] DEBUG: Loading egg plugin TracXMLRPC from /usr/lib/python2.4/site-packages/TracXMLRPC-0.1-py2.4.egg
2007-03-01 10:53:10,710 Trac[loader] DEBUG: Loading egg plugin tracreposearch from /usr/lib/python2.4/site-packages/tracreposearch-0.2-py2.4.egg
2007-03-01 10:53:10,713 Trac[loader] DEBUG: Loading egg plugin batchmod.web_ui from /usr/lib/python2.4/site-packages/BatchModify-0.1.0-py2.4.egg
2007-03-01 10:53:10,716 Trac[loader] DEBUG: Loading egg plugin acct_mgr.htfile from /usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r2063-py2.4.egg
2007-03-01 10:53:10,721 Trac[loader] DEBUG: Loading egg plugin acct_mgr.web_ui from /usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r2063-py2.4.egg
2007-03-01 10:53:10,755 Trac[loader] DEBUG: Loading egg plugin acct_mgr.admin from /usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r2063-py2.4.egg
2007-03-01 10:53:10,757 Trac[loader] DEBUG: Loading egg plugin acct_mgr.api from /usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r2063-py2.4.egg
2007-03-01 10:53:10,758 Trac[loader] DEBUG: Loading egg plugin acct_mgr.http from /usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r2063-py2.4.egg

[anonymous]

Replying to Markus Tacker <m@tacker.org>:

With r4809 (0.10-stable) I get this error.

This happened because of a missing trac.repository_dir entry in the config file.