Edgewall Software

Ticket #3325 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

trac-post-commit-hook error when both re: and fixes: keywords included

Reported by: mferrier@… Owned by: cboos
Priority: high Milestone: 0.10
Component: ticket system Version: 0.9.5
Severity: normal Keywords:
Cc:

Description

When a commit message includes both the "re: " and "fixes: " on the same ticket numbers (e.g. "re: #100 fixes: #100"), the trac-post-commit-hook script fails with the following message:

Unexpected error while processing ticket ID 8: columns ticket, time, field are not unique

The script appears to be trying to insert two rows in ticket_change with the same key field values.

Attachments

Change History

Changed 2 years ago by cboos

  • owner changed from jonas to cboos
  • priority changed from lowest to high
  • status changed from new to assigned
  • severity changed from trivial to normal
  • milestone set to 0.10

I tried to have a look at that, and I've seen that a lot of changes I've recently made have horribly broken that script...

Changed 2 years ago by cboos

  • status changed from assigned to closed
  • resolution set to fixed

Please try out r3486. It works fine for me.

Changed 2 years ago by mferrier@…

Can I use this with my 0.9.5-stable installation?

Changed 2 years ago by cboos

No way. It contains changes that are specific to the 0.10 api/data model. However, it should be possible to downgrade it. I'll have a try.

Changed 2 years ago by mferrier@…

No biggie if you can't, it's not a big deal to just not re: and close: in the same commit message. I'll upgrade to 0.10 when it's stable.

Changed 2 years ago by cboos

He, I guess we had a collision... I was about to say:

I ported the above fix to 0.9-stable in r3487. Can you please test it?

Changed 2 years ago by mferrier@…

Works great, thanks for your help.

Changed 2 years ago by anonymous

  • status changed from closed to reopened
  • resolution fixed deleted

Changed 2 years ago by eblot

  • status changed from reopened to closed
  • resolution set to fixed

anonymous: do not change the status of a ticket without a reason/description.

Add/Change #3325 (trac-post-commit-hook error when both re: and fixes: keywords included)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.