Ticket #3325 (closed defect: fixed)
Opened 6 years ago
Last modified 6 years ago
trac-post-commit-hook error when both re: and fixes: keywords included
| Reported by: | mferrier@… | Owned by: | cboos |
|---|---|---|---|
| Priority: | high | Milestone: | 0.10 |
| Component: | ticket system | Version: | 0.9.5 |
| Severity: | normal | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
When a commit message includes both the "re: " and "fixes: " on the same ticket numbers (e.g. "re: #100 fixes: #100"), the trac-post-commit-hook script fails with the following message:
Unexpected error while processing ticket ID 8: columns ticket, time, field are not unique
The script appears to be trying to insert two rows in ticket_change with the same key field values.
Attachments
Change History
comment:1 Changed 6 years ago by cboos
- Milestone set to 0.10
- Owner changed from jonas to cboos
- Priority changed from lowest to high
- Severity changed from trivial to normal
- Status changed from new to assigned
comment:2 Changed 6 years ago by cboos
- Resolution set to fixed
- Status changed from assigned to closed
Please try out r3486. It works fine for me.
comment:3 Changed 6 years ago by mferrier@…
Can I use this with my 0.9.5-stable installation?
comment:4 Changed 6 years ago by cboos
No way. It contains changes that are specific to the 0.10 api/data model.
However, it should be possible to downgrade it. I'll have a try.
comment:5 Changed 6 years ago by mferrier@…
No biggie if you can't, it's not a big deal to just not re: and close: in the same commit message. I'll upgrade to 0.10 when it's stable.
comment:6 Changed 6 years ago by cboos
He, I guess we had a collision... I was about to say:
I ported the above fix to 0.9-stable in r3487. Can you please test it?
comment:7 Changed 6 years ago by mferrier@…
Works great, thanks for your help.
comment:8 Changed 6 years ago by anonymous
- Resolution fixed deleted
- Status changed from closed to reopened
comment:9 Changed 6 years ago by eblot
- Resolution set to fixed
- Status changed from reopened to closed
anonymous: do not change the status of a ticket without a reason/description.
I tried to have a look at that, and I've seen that
a lot of changes I've recently made have horribly
broken that script...