Edgewall Software

Ticket #3260 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

code.css needs modification for php comments when using SilverCity

Reported by: Tim Hatch <trac@…> Owned by: cboos
Priority: normal Milestone: 0.10
Component: version control/browser Version: devel
Severity: normal Keywords:
Cc:

Description

My SilverCity lexer is producing the class hphp_comment for multiline (c-style) comments. This css class doesn't exist in code.css right now (although hphp_commentblock and hphp_commentinline do). This occurs with the latest SilverCity 0.9.6 built from source.

Patch attached in a sec that fixes the symptom of 'comments not displaying like comments'.

Attachments

silvercity-php-comment.diff Download (0.5 KB) - added by Tim Hatch <trac@…> 3 years ago.
diff against trunk@3397

Change History

Changed 3 years ago by Tim Hatch <trac@…>

diff against trunk@3397

Changed 3 years ago by Tim Hatch <trac@…>

Tested against SilverCity 0.9.5 also, after finding the note about 0.9.6 not working with Trac.

P.S. Tried submitting this comment once, got "Database is locked."

Changed 3 years ago by cboos

  • owner changed from jonas to cboos
  • status changed from new to assigned
  • milestone set to 0.10

What's not working with 0.9.6 is the Python highlighting mode. Shouldn't affect the PHP highglighting. I'll apply the patch in a sec.

As for the "Database is locked.", seems to be fairly frequent today :(

Changed 3 years ago by cboos

  • status changed from assigned to closed
  • resolution set to fixed

Patch applied in r3405.

Add/Change #3260 (code.css needs modification for php comments when using SilverCity)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cboos. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.