Ticket #3260 (closed defect: fixed)
Opened 6 years ago
Last modified 5 years ago
code.css needs modification for php comments when using SilverCity
| Reported by: | Tim Hatch <trac@…> | Owned by: | cboos |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.10 |
| Component: | version control/browser | Version: | devel |
| Severity: | normal | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
My SilverCity lexer is producing the class hphp_comment for multiline (c-style) comments. This css class doesn't exist in code.css right now (although hphp_commentblock and hphp_commentinline do). This occurs with the latest SilverCity 0.9.6 built from source.
Patch attached in a sec that fixes the symptom of 'comments not displaying like comments'.
Attachments
Change History
Changed 6 years ago by Tim Hatch <trac@…>
- Attachment silvercity-php-comment.diff added
comment:1 Changed 6 years ago by Tim Hatch <trac@…>
Tested against SilverCity 0.9.5 also, after finding the note about 0.9.6 not working with Trac.
P.S. Tried submitting this comment once, got "Database is locked."
comment:2 Changed 6 years ago by cboos
- Milestone set to 0.10
- Owner changed from jonas to cboos
- Status changed from new to assigned
What's not working with 0.9.6 is the Python highlighting mode.
Shouldn't affect the PHP highglighting.
I'll apply the patch in a sec.
As for the "Database is locked.", seems to be fairly frequent today :(
comment:3 Changed 6 years ago by cboos
- Resolution set to fixed
- Status changed from assigned to closed
Patch applied in r3405.
diff against trunk@3397