Edgewall Software
Modify

Ticket #3168 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

No File Upload error from WebAdmin when using install plugin function.

Reported by: skasulka@… Owned by: cmlenz
Priority: normal Milestone: 0.11
Component: admin/web Version: devel
Severity: major Keywords:
Cc:
Release Notes:
API Changes:

Description

In the 'Install Plugin:' part of WebAdmin I try to install a .egg file un the 'File:' field. I hit 'Install' and I get and error 'No file uploaded'.
Thanks
Shawn

Attachments

plugin_upload.patch (423 bytes) - added by agraham 5 years ago.
patch to the template file to allow uploads
admin_plugins.html.patch (543 bytes) - added by Dave Abrahams <dave@…> 5 years ago.
Corresponding patch for 0.11

Download all attachments as: .zip

Change History

comment:1 Changed 6 years ago by Darren Govey

I'm getting this too when using the TracVM VMWare Appliance to host Apache/Trac?/SVN.
See the TracVM project page for details.

I'm logged into Linux and Trac as "admin".

I'm using Firefox 1.5.0.6. on Windows XP SP2

The egg I tried to install was TicketDelete?-0.1-py2.3.egg, obtained from the "ticketdeleteplugin\0.9\dist" directory of this zip file (after it was extracted locally to my c: drive.

comment:2 Changed 5 years ago by agraham

Replicated with new install of 0.10rc1 and current SVN build of WebAdmin

comment:3 Changed 5 years ago by agraham

  • Version changed from 0.9.5 to 0.10

Got bored and tracked this down. The issue boils down to the plugin being uploaded being referred to by two different variable names. In plugin.py, _do_install checks for the key "plugin_file", while the template form uses the name "egg_file" for the same data. Since _do_install should accept a bare .py file as well as eggs, the template should be modified to use plugin_file.

Changing the names to match resolves the issue for me in an install based on r3772.

Changed 5 years ago by agraham

patch to the template file to allow uploads

comment:4 Changed 5 years ago by cboos

  • Milestone set to 0.11

Seems to apply to 0.11 as well.

Changed 5 years ago by Dave Abrahams <dave@…>

Corresponding patch for 0.11

comment:5 Changed 5 years ago by Dave Abrahams <dave@…>

  • Keywords 0.10, 0.11 added
  • Version changed from 0.10 to devel

It does; I added a corresponding patch.

comment:6 Changed 5 years ago by cboos

  • Keywords 0.10, 0.11 removed
  • Resolution set to fixed
  • Status changed from new to closed

Patch verified and applied in r5752. Thanks!

While I was at it, I also applied the fix to the WebAdmin plugin for 0.10 (r5753).

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cmlenz. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.