Ticket #312 (closed defect: fixed)
Opened 8 years ago
Last modified 6 years ago
Extra slash after htdocs_location in generated URLs
| Reported by: | cmlenz@… | Owned by: | jonas |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.7.1 |
| Component: | general | Version: | 0.6.1 |
| Severity: | trivial | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
Links in pages generated by trac contain an extra slash after the htdocs_location, so that URLs look like
/trac//css/trac.css
instead of the expected
/trac/css/trac.css
Attachments
Change History
comment:1 Changed 8 years ago by cmlenz@…
comment:2 Changed 8 years ago by anonymous
- Milestone set to 0.7
comment:3 Changed 8 years ago by jonas
- Resolution set to wontfix
- Status changed from new to closed
Well, this is actually a feature :) This approach will work even if htdocs_location does not end with a '/'.
But I guess that if it for some reason isn't acceptable to generate urls with double slashes we could apply the patch _and_ add some logic to make sure htdocs_location always has a trailing slash.
comment:4 Changed 8 years ago by cmlenz@…
- Resolution wontfix deleted
- Status changed from closed to reopened
Well, "not acceptable" is a bit strong. But I really think it'd be much better to make the admin get the htdocs_location right, as opposed to adding cruft (albeit minor) to each and every page generated out by Trac.
Alternatively, the htdocs_location should be set to "/trac" instead of "/trac/" by default. That'd probably be the simplest solution.
(Reopening only to get this comment noticed, not because I think the current approach is "not acceptable ;-) )
comment:5 Changed 8 years ago by cmlenz@…
Also note that many image links (such as the XML icon for RSS feeds and the icons in the timeline) do not handle a htdocs_location without trailing slash.
comment:6 Changed 8 years ago by daniel
- Milestone changed from 0.7 to 0.7.1
comment:7 Changed 8 years ago by jonas
- Resolution set to fixed
- Status changed from reopened to closed
Fixed in [527].



Patch sent to mailing list: http://article.gmane.org/gmane.comp.version-control.subversion.trac.general/161