Ticket #3101 (closed defect: fixed)
Opened 6 years ago
Last modified 5 years ago
smtp_always_cc ignored unless Trac would already be sending an email
| Reported by: | Tim Hatch <trac@…> | Owned by: | cmlenz |
|---|---|---|---|
| Priority: | highest | Milestone: | 0.10 |
| Component: | ticket system | Version: | devel |
| Severity: | major | Keywords: | smtp_always_cc notification email |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description (last modified by cboos) (diff)
This is a regression from the fix for #3057 which occured in r3231. Basically if a ticket has someone in the Cc: field, then it works fine and picks up the smtp_always_cc values as it should. However, if the Cc: field is blank, ticket/notification.py bails with the message
2006-05-01 13:08:22,117 Trac[notification] INFO: no recipient for a ticket notification
Before giving up, it should see if there are any email addresses in smtp_always_cc (and now smtp_always_bcc, which I didn't add), if those config options exist. I've made a patch for smtp_always_cc which solves the problem in my case, since I don't use bcc.
The full fix should check both cc and bcc, however now that there are two lists of addresses to check, I wonder if the "bail, no reason to notifiy" check should be moved to trac.notification instead of trac.ticket.notification?
Attachments
Change History
Changed 6 years ago by Tim Hatch <trac@…>
- Attachment trac-notification-always-cc-broken-in-r3231.patch added
comment:1 Changed 6 years ago by cmlenz
- Owner changed from jonas to cmlenz
- Status changed from new to assigned
Thanks for the patch!
I think we'll also need to check smtp_always_bcc.
comment:2 Changed 6 years ago by cmlenz
- Resolution set to fixed
- Status changed from assigned to closed
Modified patch applied in [3273].
comment:3 Changed 6 years ago by eblot
(non-regression test added in r3280)
comment:4 Changed 5 years ago by cboos
- Description modified (diff)
(fixed description formatting after deletion of a "test" comment)
Rough patch against trunk (r3257)