Edgewall Software
Modify

Opened 9 years ago

Closed 8 years ago

#3073 closed defect (fixed)

download in original format of source attachments fails (.bat and .py)

Reported by: patrickmmartin@… Owned by: jonas
Priority: normal Milestone:
Component: wiki system Version: devel
Severity: normal Keywords:
Cc:
Release Notes:
API Changes:

Description (last modified by mgood)

got to

http://projects.edgewall.com/trac/attachment/ticket/1602/trac-post-commit-hook_4bat

and click on the original format link

I got an error once.

Amusingly, not the second time.

So I'm afraid all I can remember is something about "not iterable" and mime-type

Attachments (0)

Change History (5)

comment:1 Changed 9 years ago by anonymous

  • Severity changed from minor to normal
  • Summary changed from download in original format of batch file fails to download in original format of source attachments fails (.bat and .py)

got this error again on downloading a .py attachment, this time

http://projects.edgewall.com/trac/attachment/ticket/1602/trac-pre-commit-hook_4bat.2

and here's the traceback

Traceback (most recent call last):

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 299, in dispatch_request

dispatcher.dispatch(req)

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 189, in dispatch

resp = chosen_handler.process_request(req)

File "/usr/lib/python2.3/site-packages/trac/attachment.py", line 289, in process_request

self._render_view(req, attachment)

File "/usr/lib/python2.3/site-packages/trac/attachment.py", line 444, in _render_view

if 'charset=' not in mime_type:

TypeError?: iterable argument required

This one seems 100% reproducible now.

Using IE 6

I went to

http://projects.edgewall.com/trac/wiki/TracOnWindows

clicked on new window for the link

http://projects.edgewall.com/trac/ticket/1602

and clicked on new window for the links for the attachments I wanted.

Then go to the original format link

comment:2 Changed 9 years ago by anonymous

  • Component changed from browser to wiki

comment:3 Changed 9 years ago by cboos

  • Description modified (diff)
  • Version changed from 0.9.5 to devel

I believe this was fixed in r3225 (and this Trac is certainly running using a slightly older rev).

comment:4 Changed 9 years ago by patrickmmartin@…

Is this fix in a testable release, or should this report be closed now?

comment:5 Changed 8 years ago by mgood

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from new to closed

This is working on the attachments to #1602 mentioned above now that the site has been updated, so I believe that [3225] did resolve the problem.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed The owner will remain jonas.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jonas to the specified user.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.