require username, comment when changing stuff

[joramagten@…]

when editing a wiki page, roadmap, timeline, ... require an author and comment

this to force users to add comments when committing I edited the function save in source:trunk/trac/wiki/model.py

    def save(self, author, comment, remote_addr, t=None, db=None):
        ...
        if t is None:
            t = time.time()

        if author == None or author == "" :
            raise TracError('Author field is empty')

        if comment == None or comment == "" :
            raise TracError('Comment field is empty')

        if self.text != self.old_text:
            cursor = db.cursor()
        ...

also in source:/trunk/templates/wiki.cs " (optional)" should be removed

248 	     <div class="field">
249 	      <label>Comment about this change (optional):<br />
250 	      <input id="comment" type="text" name="comment" size="60" value="<?cs
251 	        var:wiki.comment?>" /></label>
252 	     </div><br />

• maybe this should better be done with an option in the config file
• it might also be better to handle this in the POST processing of the form and color the field RED?

[eblot]

At best, this could be defined as an option.

I personally use a Javacript to pop out a question to the user whether he's sure he wants to commit a new version of a wiki page without a comment.

(changing the ticket type: this is not a defect)

[joramagten@…]

you're right, this is not a defect at all, sorry about that

that's also an interesting option, can you share the Javascript with us? thanks in advance

[eblot]

Javascript to prompt the user about comment-less wiki page update

[eblot]

Sample of a Javascript add-on that:

• hides the wiki page Save button if the user has not previewed her changes
• prompts the user if she attempts to save the changes without adding a comment

[cboos]

A IWikiManipulator anyone?

The work Alec did for tickets could be leveraged here for wiki pages.