Attaching files to tickets [merge]

[jonas]

It should be possible to attach files (for example: patches and screenshots) to tickets.

[jonas]

This should probably be implemented to work with both tickets and wiki pages.

[rocky]

This is nearing completion. All work for this feature is being done in the /branches/rocky-dev/features/ticket_attachment_support-based_on_trunk branch.

[rocky]

Outstanding items to complete with this are:

1) Change use of TRAC_REPOS to TRAC_ENV
2) Switch from camelcase to more typical python conventions
3) Change path usage to use os.path.join

[rocky]

Outstanding items have been completed.

[jonas]

Merged in [409].

We still need to add a max size limit before closing this ticket.

[daniel]

Also, attaching another file with the same name as an existing attachment, overwrites the existing file.

The proper way is probably to append '.N' to the name where N is a sequence number. If the file has a suffix (like .png), the sequence number should be added before the prefix.

Example:

• Attach test.png
• Attach another file named test.png => renamed test.1.png
• Attach test
• Attach another file named test => renamed test.1

[rocky]

So what we're basically talking about adding here are the following..

• Add default max size limit
• Allow max size limit to be configurable
• Attachments added with same name should get auto-numbered so they don't overwrite
• Ability to delete attachments

[jonas]

max size limit added now.

Things left todo:

• auto-number files to avoid overwrites
• delete support.

[jonas]

Fixed in [445].

[anonymous]

tesy