Edgewall Software

Ticket #2545 (closed enhancement: fixed)

Opened 3 years ago

Last modified 20 months ago

Browser should show SVN revision properties

Reported by: eblot Owned by: cboos
Priority: low Milestone: 0.11
Component: version control/changeset view Version: devel
Severity: minor Keywords: properties
Cc: thomas.tressieres@…

Description

Note: This RFE refers to Trac with SVN back-end, but could also be applied to other backend, such as Mercurial back-end.

Trac browser shows file-based properties (for example, svn:ignore).

However, it ignores revision-based properties.
It would be nice if Trac were able to show this kind of properties as well.

Attachments

svn_chgset_get_properties_r3116.diff (1.9 kB) - added by cboos 2 years ago.
Initial implementation of the feature

Change History

  Changed 3 years ago by cboos

  • owner changed from jonas to cboos
  • status changed from new to assigned
  • milestone set to 1.0

Are you sure you want to see those properties in the TracBrowser, not in the TracChangeset view?

  Changed 3 years ago by eblot

  • component changed from browser to changeset view

You're right, it makes (more) sense to have it in the TracChangeset view.

Changed 2 years ago by cboos

Initial implementation of the feature

  Changed 2 years ago by cboos

  • keywords properties added
  • milestone changed from 1.0 to 0.11

I've uploaded an initial implementation for this. What remains to be done, is a way to associate a plaintext flag as well as an htmlclass (one of time, author, message or changeset) to the property (see the API).

Or perhaps reuse some of the forthcoming mechanisms for rendering node properties (see #1601).

follow-up: ↓ 5   Changed 23 months ago by ttressieres

  • cc thomas.tressieres@… added

do you think the patch could be applied in 0.10.1 or 0.11 Trac version ? I need it to implement the feature in http://trac-hacks.org/ticket/628.

in reply to: ↑ 4   Changed 23 months ago by mgood

Replying to ttressieres:

do you think the patch could be applied in 0.10.1 or 0.11 Trac version

This is scheduled for 0.11. Upcoming 0.10.x releases will only contain bugfixes.

follow-up: ↓ 7   Changed 23 months ago by cboos

Yes, I'll commit the patch (for 0.11) but be prepared for possible interface change once #1601 progresses...

in reply to: ↑ 6   Changed 23 months ago by ttressieres

Replying to cboos:

Yes, I'll commit the patch (for 0.11) but be prepared for possible interface change once #1601 progresses...

Yes, i saw this ticket too, i'll be prepared... thank you.

  Changed 23 months ago by cboos

  • status changed from assigned to closed
  • resolution set to fixed

Patch updated and applied in r4130.

  Changed 20 months ago by cboos

As advertised, the revision properties are now rendered using the IPropertyRenderer from #1601.

Please take a look at the source:sandbox/property-renderers-tmp@4530 (see Last Change from there); I'd be interested in eventually getting some feedback before integrating that work branch in trunk.

  Changed 20 months ago by eblot

I just gave a try. It seems to work fine w/ my custom properties. Thanks!

As a small enhancement, I think the custom properties should be more visible, or at least differenciated from the regular SVN properties. Maybe a different color/style (CSS), and all custom properties grouped as they are now, but separated from the regular properties with a blank line or the like.

I'm thinking about another enhancement - that could be done through another ticket though: it would be nice if it was possible to define a property-to-name mapping in trac.ini. For example, svn:log is shown as Message, svn:author as Author. It would be great to define custom property names in the config file, such as in the following example

[svnprops]
my:version = Version

  Changed 20 months ago by cboos

See also r4618, which introduces the possibility to have even more control over the rendered property, by returning a RenderedProperty instance instance of just text or markup - which is still possible, of course. This is especially useful for changeset properties.

  Changed 20 months ago by cboos

Support for RenderedProperty (in addition to plain text and Markup return values) merged in trunk in r4655.

Add/Change #2545 (Browser should show SVN revision properties)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.