Milestone progess bars don't fill their bounding box

[markus]

[2411] led to another layout issue as the inner progress bars (completed & new/assigned/reopened) never fill the complete bounding box. This is ugly and confusing since there's a region on the right of your progress bar where you can "see through" the bar and that doesn't link to any query.

This issue is reproducible with any Trac 0.9+ installation on any browser I tested so far (Firefox, Mozilla, Opera, Internet Explorer).

[markus]

This worksformarkus! ;-)

htdocs/css/roadmap.css

@@ -5 +5 @@
  border: none;
  display: block;
  float: left;
+ clear: right;
  height: 1.2em;
 }
 div.progress :link:hover, div.progress :visited:hover { background: #fff }

templates/milestone.cs

@@ -126 +126 @@
         if:#stats.total_tickets != #1 ?>s<?cs /if ?> closed"></a>
       <a class="open" href="<?cs
         var:milestone.queries.active_tickets ?>" style="width: <?cs
-        var:#stats.percent_active - 1 ?>%" title="<?cs
+        var:#stats.percent_active ?>%" title="<?cs
         var:#stats.active_tickets ?> of <?cs
         var:#stats.total_tickets ?> ticket<?cs
         if:#stats.total_tickets != #1 ?>s<?cs /if ?> active"></a>

templates/roadmap.cs

@@ -46 +46 @@
          if:#stats.total_tickets != #1 ?>s<?cs /if ?> closed"></a>
        <a class="open" href="<?cs
          var:milestone.queries.active_tickets ?>" style="width: <?cs
-         var:#stats.percent_active - 1 ?>%" title="<?cs
+         var:#stats.percent_active ?>%" title="<?cs
          var:#stats.active_tickets ?> of <?cs
          var:#stats.total_tickets ?> ticket<?cs
          if:#stats.total_tickets != #1 ?>s<?cs /if ?> active"></a>

See also #1886.

[Christopher Lenz]

Will look into this.

[markus]

After talking to cmlenz we decided to fix this ticket another way. The patch I just attached is a preview of my proposal. Unfortunately the final version won't be finished for the next release, sorry… :(

[Christopher Lenz]

Applied a slightly modified version of the patch in [2906] and [2907]. Thanks!