Edgewall Software

Ticket #2330 (closed defect: fixed)

Opened 3 years ago

Last modified 23 months ago

summary href URL not correctly rendered if not t.id in the query

Reported by: alessandro.ogier@… Owned by: cmlenz
Priority: low Milestone: 0.9.4
Component: report system Version: 0.9
Severity: minor Keywords:
Cc:

Description

if the custom query does not SELECT ticket.id, the href of every ticket summary will be the report page itself.

to reproduce, create a custom report with an appropriate select query.

Attachments

Change History

Changed 3 years ago by alessandro.ogier@…

a simple, not too intrusive workaround would be :

--- report_original.py  2005-11-10 00:44:01.608853132 +0100
+++ report.py   2005-11-10 00:46:12.778042759 +0100
@@ -338,9 +338,9 @@
                 elif column[0] == '_':
                     value['hidehtml'] = 1
                     column = column[1:]
-                if column in ['id', 'ticket', '#', 'summary']:
+                if column in ['id', '_id', 'ticket', '#', 'summary']:
                     id_cols = [idx for idx, col in util.enum(cols)
-                               if col[0] in ('ticket', 'id')]
+                               if col[0] in ('ticket', 'id', '_id')]
                     if id_cols:
                         id_val = row[id_cols[0]]
                         value['ticket_href'] = self.env.href.ticket(id_val)

so

                    if id_cols:
                        id_val = row[id_cols[0]]
                        value['ticket_href'] = self.env.href.ticket(id_val)

doesn't break

Changed 3 years ago by anonymous

  • priority changed from normal to high
  • severity changed from major to blocker

Changed 3 years ago by cmlenz

  • priority changed from high to normal
  • severity changed from blocker to major

Changed 3 years ago by alessandro.ogier@…

  • priority changed from normal to high

so no fix even in the 0.9.3 :|

ehi, there's already a patch, it's a BIG PAIN to manually patch sources every upgrade i do :(

Changed 3 years ago by cmlenz

  • owner changed from daniel to cmlenz
  • priority changed from high to low
  • status changed from new to assigned
  • severity changed from major to minor
  • milestone set to 0.9.4

Changed 3 years ago by cmlenz

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in [2895] and [2896].

Add/Change #2330 (summary href URL not correctly rendered if not t.id in the query)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.