plugins may fail to load on windows

[Geoff Reedy <gereedy@…>]

Plugins installed to a project's plugins directory may not be automatically enabled due to windows' case preserving yet case insensitive behavior.

trac.loader directly compares the location of each plugin's egg with the environment's plugin path without normalization, the following patch normalizes the paths before comparing them.

trac/loader.py

@@ -26 +26 @@
 
 __all__ = ['load_components']
 
+def normalize_path(s):
+  return os.path.normcase(os.path.abspath(s))
+
+def paths_equal(path1, path2):
+  return normalize_path(path1) == normalize_path(path2)
+
 def load_components(env):
 
     loaded_components = []
@@ -45 +51 @@
     def enable_modules(egg_path, modules):
         """Automatically enable any components provided by plugins loaded from
         the environment plugins directory."""
-        if os.path.dirname(egg_path) == os.path.realpath(plugins_dir):
+        if paths_equal(os.path.dirname(egg_path), os.path.realpath(plugins_dir)):
             for module in modules:
                 env.config.setdefault('components', module + '.*', 'enabled')
 

[Christian Boos]

Yep, that's a better fix than what I did in r2471.

[Christian Boos]

Patch applied in r2525.

cmlenz, I let you port this on 0.9-stable and close the ticket if you find the change OK.

[Christian Boos]

Ported to stable in r2532.